fluent
dockerfile: Enable default SIMD support in Docker (#10215)
According to the documentation, SIMD is supposed to be enabled by default in Fluent Bit container images.
This commit updates the Dockerfile to reflect that, enabling SIMD by default.
Closes #10215
Testing Before we can approve your change; please submit the following in a comment:
- [N/A] Example configuration file for the change
- [N/A] Debug log output from testing the change
- [N/A] Attached Valgrind output that shows no leaks or memory corruption was found
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
- [N/A] Run local packaging test showing all targets (including any new ones) build.
- [N/A] Set
ok-package-testlabel to test for all targets (requires maintainer to do).
Documentation
- [N/A] Documentation required for this feature
Backporting
- [N/A] Backport to latest stable release.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
I think it makes sense to wait until this ticket(#10178) is completed before proceeding. I’ll hold off for now.
@jinyongchoi looks like those PR's were merged. Can we move forward here as we'd love to have a boost in json processing as well.
@patrick-stephens @cdancy Hello, I've enabled the FLB_SIMD option by default in all Dockerfiles except for Dockerfile.centos7, which is used for internal testing. If the SIMD option should also be enabled there, please let me know and I’ll update it accordingly. Thank you!
@patrick-stephens @cdancy Hello, I've enabled the FLB_SIMD option by default in all Dockerfiles except for Dockerfile.centos7, which is used for internal testing. If the SIMD option should also be enabled there, please let me know and I’ll update it accordingly. Thank you!
I would as it's intended to verify Centos 7 builds and you've enabled it for the actual builds themselves I think
@patrick-stephens @cdancy Hello, I've enabled the FLB_SIMD option by default in all Dockerfiles except for Dockerfile.centos7, which is used for internal testing. If the SIMD option should also be enabled there, please let me know and I’ll update it accordingly. Thank you!
I would as it's intended to verify Centos 7 builds and you've enabled it for the actual builds themselves I think
I've updated Dockerfile.centos7 to include the SIMD option as suggested.
Please let me know if there's anything else you'd like me to adjust.
Thanks again!
Hi all, any chance we could get this merged and released in the near future?
@jinyongchoi can you update the new Alma and Rocky targets as well?
@edsiper we can merge this I think after that is done.
@patrick-stephens Sure, I'll update the Alma and Rocky targets as well.
OK thanks, I will merge after that if it looks good unless @edsiper disagrees.
@patrick-stephens Added Alma and Rocky. Let me know if anything else is needed!
Hi~ @edsiper, This should be ready for review now. Let me know if there's anything else you'd like me to change.
Hi @patrick-stephens, Thank you for your work on this PR. We are looking forward to this change and were wondering if there's an estimated release date for it. Could you also let us know if it's being considered for inclusion in a future Fluent Bit 3.2.x release?
It'll be in the next 4.x release, probably next week or so.
To get it in a 3.2 release it needs backporting to the 3.2 branch but I doubt it'll go into a release there unless someone pushes for it and makes the PR. 3.2 is really only getting critical fixes now.