fluent-bit-docs icon indicating copy to clipboard operation
fluent-bit-docs copied to clipboard

outputs: loki output add worker configuration paramenter

Open toledompm opened this issue 3 years ago • 3 comments

Worker parameter is missing from most outputs documentation, copied it from stdout docs. I recently discovered it worked by digging through some github issues. Is this config available for all outputs? And if so is there a more centralized doc where this should be / already is available?

toledompm avatar Aug 02 '22 14:08 toledompm

hi @toledompm, you can use the workers parameter in Loki, however, it doesn't have a default value of 1. This is available for all output plugins.

lecaros avatar Aug 19 '22 21:08 lecaros

Hey @lecaros, thanks for the reply! Just have a couple of questions:

it doesn't have a default value of 1.

I skimmed over some source code, is the default 0?

This is available for all output plugins.

Should there be a general output doc? Recently we ran into some issues with backpressure that got fixed after we increased our output workers, but we only found out that was a thing after seeing it mentioned in the Kinesis output docs

toledompm avatar Aug 22 '22 17:08 toledompm

hi @toledompm the default is no workers. Meaning it will run on the same thread the other components are running. We currently don't have documentation for Outputs in general; that's a good idea. We always welcome PRs :)

lecaros avatar Sep 02 '22 19:09 lecaros

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 02 '22 02:12 github-actions[bot]