fluent-bit-docker-image icon indicating copy to clipboard operation
fluent-bit-docker-image copied to clipboard

Incorrect version in Dockerfile in 1.0 branch

Open varun-da opened this issue 7 years ago • 0 comments

In the line https://github.com/fluent/fluent-bit-docker-image/blob/1.0/1.0/Dockerfile#L12, it picks up master.zip, as long as master matches ENV FLB_VERSION 1.0.1 things are fine, when master changes, this will not be fine. Best to use v$FLB_VERSION.zip similar to https://github.com/fluent/fluent-bit-docker-image/blob/0.14/0.14/Dockerfile#L11.

The docker layout is also a bit confusing because these previous versions also exists in v1.0:

  • https://github.com/fluent/fluent-bit-docker-image/blob/1.0/0.14/Dockerfile
  • https://github.com/fluent/fluent-bit-docker-image/blob/1.0/0.12/Dockerfile

And a Dockerfile exists in the main fluent-bit repo:

  • https://github.com/fluent/fluent-bit/blob/master/Dockerfile

Docker hub images are produced from this repo: https://hub.docker.com/r/fluent/fluent-bit, so I guess the Dockerfile from the main repo can be ignored and is used for dev purposes?

varun-da avatar Jan 08 '19 18:01 varun-da