flucoma-sc icon indicating copy to clipboard operation
flucoma-sc copied to clipboard

Proposal: remove arg server from buf processes

Open elgiano opened this issue 3 years ago • 1 comments

I know this is a breaking interface change, but since it's impossible to have a buffer on one server and run the analysis on another, I think the server argument is redundant for all buffer processes. Such processes can get the server instance from the source buffer that gets passed to them:

// in, e.g. FluidBufMFCC.process
^this.new(src.server, nil, [features])
// instead of: ^this.new(server, nil,[features])

Since BufProcesses have already lots of args usually, I think that removing a redundant one would contribute to cleaner (e.g. more understandable/actionable) code

elgiano avatar Aug 17 '22 10:08 elgiano

Good point (and I guess we should assert that the server for each passed Buffer actually matches). The scale of breakage will be pretty immense though, so I'd be inclined to think carefully about how / when such a change could be deployed. It might be more of a v2 thing?

weefuzzy avatar Aug 22 '22 10:08 weefuzzy