angular-underscore icon indicating copy to clipboard operation
angular-underscore copied to clipboard

Registering filters 3 times

Open Timvissers opened this issue 10 years ago • 1 comments

Hello,

You are registring the filters in the underscore, the filters and the specific filter (per name) module. This means a filter with the same name is registered 3 times. Of course you can choose what module you are loading as a dependency of an application.

I just wanted to mention that I think it's not good practice to load a filter with a certain name 3 times. And scripts like stop-angular-overrides are treating this as errors (which is good imho).

Best regards, Tim

Timvissers avatar Aug 06 '15 09:08 Timvissers

+1

bastijns-jeroen avatar Aug 06 '15 13:08 bastijns-jeroen