fips run does not take into account FIPS_DEPLOY_DIR

[avixz]

Working directory for fips run seems to be always relative to FIPS_ROOT_DIR instead of taking into account FIPS_DEPLOY_DIR.

Steps to reproduce:

• Set up a standalone app (e.g. oryol-test-app)
• Set get_filename_component(FIPS_DEPLOY_DIR "bin" ABSOLUTE) in project level CMakeLists.txt before fips_setup()
• Set a cwd for the target in fips.yml:

run:
    test:
        cwd: bin

• Try to run with "fips run test"

Great work by the way :)

[floooh]

Hmm it didn't occur to me yet to simply modify FIPS_DEPLOY_DIR before running fips_setup() in order to move the target directory somewhere else. Does this work as expected apart from 'fips run'? It sounds like a useful feature (I was actually planning to make it an 'official feature' to move the deploy dir somewhere else, I just didn't think of the simple solution to move the FIPS_DEPLOY_DIR variable)...

[avixz]

I have only tested the Hello World oryol sample but it seems to work as expected.

[clumbo]

I too would like to bump this issue, having the build BACK outside the project can cause issues with certain CI systems. Thanks

[floooh]

Ok, noted, I'll try to sneak in some time :) It may be necessary to move the setting into the fips.yml file though, because if it is just done inside the cmake file it wouldn't be visible in the python fips scripts (at least without hacks).

So basically, you could say in your toplevel project fips.yml something like:

fips_deploy_dir: path_to_deploy_dir

I'd still like to avoid absolute directories in config files, so the path 'path_to_deploy_dir' would be relative to the top-level project directory.

It probably makes sense to do the same for fips_build_dir.

[clumbo]

Great that makes sense to me. Thanks