phony icon indicating copy to clipboard operation
phony copied to clipboard
verified publisher icon floere

Upgrade rubyies on travis

Open berkos opened this issue 6 years ago • 3 comments

👋

  • Upgrade to latest Rubies on Travis.
  • Remove Gemfile.lock to relax dependancies between different Ruby versions.

note: Gemfile.lock is bundled with a specific version of bundler, not sure if there is a reason to keep the lock file as versions can locked from gemspec.

Thanks!

berkos avatar Mar 16 '19 09:03 berkos

Coverage Status

Coverage decreased (-0.0002%) to 99.368% when pulling e701247c0dcfd63a11f71aa4a858ef9c6b0244f8 on berkos:upgrade_rubyies_on_travis into cee52fe31304bae33971386584d40f9658f504a0 on floere:master.

coveralls avatar Mar 16 '19 09:03 coveralls

@berkos Hi Antonis! Thanks for the PR – I like that you added the versions for Travis 👍 Much appreciated. Regarding the Gemfile.lock – the lock is for developing the gem itself, to ensure that contributors have the same versions as I do when developing. The gemspec is for the gem's dependencies itself. They have different purposes. So if you could revert e701247, I'd be happy to pull this PR (or you could convince me, that would be fine also 😊) Cheers and thanks again!

floere avatar Mar 17 '19 00:03 floere

@berkos Hi Antonis! Thanks for the PR – I like that you added the versions for Travis 👍 Much appreciated. Regarding the Gemfile.lock – the lock is for developing the gem itself, to ensure that contributors have the same versions as I do when developing. The gemspec is for the gem's dependencies itself. They have different purposes. So if you could revert e701247, I'd be happy to pull this PR (or you could convince me, that would be fine also 😊) Cheers and thanks again!

Hi @floere. Thanks very much for your reply! Ruby 2.5.5 was failing as Bundler 1.16.6 was not available in that version. Also of the reasons that I had the Gemfile.lock removed is because given it's a library you want to it to be available to work with a variety of clients(apps) at the moment the tests for an instance run with versions that are declared in the lock file. If someone would use the gem in his Gemfile would possible used latest version that the one used to be developed, gemspec would allow this, but the tests of the library would not have run against these versions.

I could not find an official documentation but here are some articles. https://depfu.com/blog/2017/01/18/bundler-and-gemfile-best-practices https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

I might missing something in the flow so either way I am happy to remove .lock. Again thanks for you reply and your time 😊.

berkos avatar Mar 17 '19 11:03 berkos