floccus icon indicating copy to clipboard operation
floccus copied to clipboard

Cookie hack

Open pogobanane opened this issue 5 years ago • 2 comments

Keep auth cookies in a cookie jar which is seperated from the users cookie jar. Leads to nextcloud servers not having to verfifyPassword for each request.

@marcelklehr Please check especially Account.js and Controller.js if you are ok with what i changed. I only fixed a single test. I will fix the others as soon as you approve Account.js and Controller.js.

Working/Used test: /dist/html/test.html?pw=admin-pass&server=https://192.168.178.117&grep=Floccus nextcloud-folders benchmark standard-root Account with two clients should handle deep hierarchies with lots of bookmarks

Test results: with this patch (firefox): ~160000ms 170s with this patch (chrome): ~90000ms 100s without this patch (firefox): ~210000ms 255s

pogobanane avatar Apr 13 '20 13:04 pogobanane

heh, the green checkmark is deceiving... :D

marcelklehr avatar Apr 13 '20 15:04 marcelklehr

I've started a real CI run on this :) https://travis-ci.org/github/marcelklehr/floccus/builds/674471321

marcelklehr avatar Apr 13 '20 15:04 marcelklehr