flintlib
flint_abort does not exist in flint library
I decided to build Arb in the new linux subsystem of Windows and when I did a make check, I got the following:
CC ../build/fmpr/test/t-abs_bound_le_2exp_fmpz
/tmp/ccyuIK39.o: In function main': t-abs_bound_le_2exp_fmpz.c:(.text.startup+0x396): undefined reference to flint_abort'
collect2: error: ld returned 1 exit status
make[1]: *** [../build/fmpr/test/t-abs_bound_le_2exp_fmpz] Error 1
make[1]: Leaving directory `/home/therickaman/libs/arb/arb/fmpr'
I decided to verify that flint_abort was missing from the flint source code by issuing grep -R flint_abort ./ from within the source code directory for flint. It returned no instances of flint_abort.
NOTE: Cloning from Fredrick's git repository of flint makes this work, but not Bill Hart's flint repository.
It should be in Bill's repository too... can you double check that you have the right version built?
However, I see now that flint_abort is not in the latest release of flint, and we need to support that.
@thofma can you think of a good solution? I think maybe the easiest thing would be to add a #define HAVE_FLINT_ABORT in flint.h and then check for this in Arb, aliasing flint_abort to abort if it's not present.
Strange, flint_abort is definitely in Bill's repository.
@fredrik-johansson Your solution does sound good. But we should ask @wbhart if he knows an alternative solution.
You can probably check the flint version. We could change that to 2.6.0 in our repositories and then you can check for 2.6.0. But it's really up to Fredrik.
Yes, increasing the version number ought to work.
It's going to break for anyone who has an old git checkout of flint with version number 2.5 and flint_abort defined. But that can't be helped.
I changed it to 2.5.3 in my repo, the reasoning being that if someone finds a severe issue in Flint that we need to issue a patch release for urgently, we'll want to use the 2.5.3 not the 2.6.0. The effect should be the same for Arb, which will just check if the version is >= 2.5.3.
On 2 March 2017 at 16:18, Fredrik Johansson [email protected] wrote:
Yes, increasing the version number ought to work.
It's going to break for anyone who has an old git checkout of flint with version number 2.5 and flint_abort defined. But that can't be helped.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fredrik-johansson/arb/issues/178#issuecomment-283681948, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOzplS9OHjU8LY4dVKtLCqSh_7esbBEks5rht3UgaJpZM4MQwqu .
FLINT_RELEASE > 20502
On 2 March 2017 at 16:26, Fredrik Johansson [email protected] wrote:
What is the correct way to compare version numbers?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fredrik-johansson/arb/issues/178#issuecomment-283684238, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOzpmJKTEj1gLPgtsIbcPQInLwwkHzkks5rht-kgaJpZM4MQwqu .
Or even better (since it is correct):
__FLINT_RELEASE > 20502
On 2 March 2017 at 16:32, Bill Hart [email protected] wrote:
FLINT_RELEASE > 20502
On 2 March 2017 at 16:26, Fredrik Johansson [email protected] wrote:
What is the correct way to compare version numbers?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fredrik-johansson/arb/issues/178#issuecomment-283684238, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOzpmJKTEj1gLPgtsIbcPQInLwwkHzkks5rht-kgaJpZM4MQwqu .
It should be in Bill's repository too... can you double check that you have the right version built?
I am very sorry for the confusion. Yes, it is in his repository. I just could not get his to pass all the tests. I just saw two failures and assumed that it was from the same issue. I'll report on the issue I am having with that library soon.