piaware icon indicating copy to clipboard operation
piaware copied to clipboard
verified publisher icon flightaware

deprecated netstat

Open a36233 opened this issue 8 years ago • 5 comments

Please change or add support to ss instead of using deprecated tool netstat.

sudo[29679]: piaware : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/usr/bin/netstat --program --tcp --wide --all --numeric piaware[29674]: failed to run netstat: piaware[29674]: child process 29679 exited with status 255

a36233 avatar Mar 02 '18 11:03 a36233

What distro are you using that's missing netstat?

mutability avatar Mar 02 '18 14:03 mutability

ArchLinux

a36233 avatar Mar 02 '18 14:03 a36233

Given that I don't build/test for Arch, I'd need a patch for this.

mutability avatar Mar 02 '18 14:03 mutability

Other distributions will follow to drop net-tools and move on with iproute2 for shure, including debian based distros. E.g: https://lists.ubuntu.com/archives/ubuntu-devel/2017-January/039651.html For now as a workaround I just disabled verifications using netstat. Two solutions to solve this:

  • verify if netstat (net-tools) exist or ss (iproute2) and split output verifications based on both.
  • Change detection method to other tool.

a36233 avatar Mar 02 '18 14:03 a36233

I'm not against moving to ss and friends if

  1. you (or someone else) can provide a suitable patch; and
  2. you can validate that it doesn't break older systems

(note that piaware already uses iproute2 for some things)

The short term fix for Arch would be for the Arch build to depend on net-tools.

mutability avatar Mar 02 '18 14:03 mutability