tidy3d icon indicating copy to clipboard operation
tidy3d copied to clipboard

Added shift_field and outer_dot_shifted function to ElectroMagneticFi…

Open prashkh opened this issue 1 year ago • 5 comments

…eldData Class

@momchil-flex Based on your suggestion a few weeks ago, I started adding functions to the ElectroMagneticFieldData class so that we can easily shift fields and do mode overlaps. Let me know if this is what you were thinking of for implementation. I checked the results of the new outer_dot_shifted with the results fromouter_dot when the relative shift is (0,0) and things are consistent.

prashkh avatar Aug 22 '24 19:08 prashkh

@momchil-flex thanks for the feedback and the detailed explanation. I think the approach you described makes sense now. Let me try to implement that sometime next week and I'll let you know if I run into any issues.

prashkh avatar Aug 23 '24 20:08 prashkh

Will this resolve this issue? https://github.com/flexcompute/tidy3d/issues/1526

caseyflex avatar Sep 03 '24 08:09 caseyflex

Will this resolve this issue? #1526

Yeah I reference it in my comment. It just needs to be done a bit more carefully and tested.

momchil-flex avatar Sep 03 '24 08:09 momchil-flex

Will this resolve this issue? #1526

Yeah I reference it in my comment. It just needs to be done a bit more carefully and tested.

Maybe the link was wrong in your comment?

caseyflex avatar Sep 03 '24 08:09 caseyflex

Ah you are right sorry! Updated it just in case someone clicks it in the future.

momchil-flex avatar Sep 03 '24 08:09 momchil-flex