fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Flash renders in wrong place when creating a new user

Open RachelElysia opened this issue 3 years ago • 1 comments

Fleet version: (head to the "My account" page in the Fleet UI or run fleetctl --version)

Operating system: (e.g. macOS 11.2.3)

Web browser: (e.g. Chrome 88.0.4324)


🧑‍💻  Expected behavior

Steps:

  1. Create a new user based on invite and open invite link in email
  2. Fill out form on App from email link to create password
  3. Redirects to login page to enter email and password (flash message renders that registration is successful and for security purposes please log in)
  4. Log in ✅

💥  Actual behavior

Flash message rendering on step 4 AFTER logging in and not on step 3 directed to log in. (Too fast to screenshot)

In frontend code: renderFlash( "success", "Registration successful! For security purposes, please log in." );

This flash message should render when

More info

Dev steps:

  • [ ] Move flash message to appropriate step in creating invited user
  • [ ] Ensure flash message shows for 4 seconds like other success flash messages

RachelElysia avatar May 06 '22 18:05 RachelElysia

@RachelElysia Will this be fixed with the spinner refactor work you have been working on or is this a separate issue? If this will be fixed can this be moved over to QA column?

xpkoala avatar Aug 11 '22 16:08 xpkoala

This was already fixed-- I just tested it, closing this out.

RachelElysia avatar Aug 16 '22 17:08 RachelElysia