Add Santa for macOS as a Fleet-maintained app
- Add Santa as a Fleet-maintained app
@allenhouchins Thanks for opening this PR. Attached, please find an SVG of the app icon. Please add this to the PR like so, and update the index.ts file like this.
Thanks! cc @mostlikelee
UPDATE: @noahtalerman: DONE. I added back the outputs/apps.json file.
Whoops! I meant to remove the changes from the outputs/apps.json file. Not the entire file. Working on adding that file back...
Why remove the outputs/apps.json file? This is autogenerated by the EM (@mostlikelee) during step 3 in testing Fleet-maintained apps:
Tim, can you please check that the name for the new app matches the name that shows up in Fleet's software inventory? And generate the outputs/apps.json file.
Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 64.13%. Comparing base (
f76516e) to head (d9b817b). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...tend/pages/SoftwarePage/components/icons/Santa.tsx | 50.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #29806 +/- ##
==========================================
- Coverage 64.18% 64.13% -0.06%
==========================================
Files 1887 1874 -13
Lines 184999 182958 -2041
Branches 5443 5361 -82
==========================================
- Hits 118739 117333 -1406
+ Misses 56924 56419 -505
+ Partials 9336 9206 -130
| Flag | Coverage Δ | |
|---|---|---|
| frontend | 53.51% <50.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Yay for the reviews!
For transparency cc: @allenhouchins @jmwatts
Noah and I walked through this addition yesterday and I finished it up but hadn't had time today to double check our process. I will confirm and update our process docs draft PR before handing it over to @jmwatts for testing. Targeting tomorrow afternoon as I want to finish my parts for @allenhouchins 's other 2 PRs to reduce context switching on myself and @jmwatts
Per step 4 and 6 in ee/maintained-apps/README.md#testing
This is ready for you @eashaw and @jmwatts -- I assigned y'all <3
Heads up @eashaw it wouldn't let me assign you I think because you already approved, but just a heads up
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
✨ Finishing Touches
🧪 Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
- [ ] Commit unit tests in branch
allenhouchins-add-santa-to-fma
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Explain this complex logic. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai explain this code block. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and explain its main purpose. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate docstringsto generate docstrings for this PR. -
@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR. -
@coderabbitai auto-generate unit teststo generate unit tests for this PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.