Past activities: script contents are updated

[jmwatts]

Fleet version: v4.65.0 (probably earlier)

Web browser and operating system: n/a

---

💥  Actual behavior

Initial script run details:

Same details of same script run after I've edited the script (did not re-run the script on the host)

🧑‍💻  Steps to reproduce

1. Upload a script
2. Run the script on a host and view the activity details for that script run. Note: this provides an accurate picture of what was run on the host and what the results were.
3. Edit the script in /controls/scripts to do something completely different
4. View the activity details for the previous script run in the host record. Note: This now shows the new script contents but the old output. This is problematic if the IT admin is trying to figure out why a script failed but it has been edited since it failed.

🕯️ More info (optional)

N/A

🛠️ To fix

• Figma

[sharon-fdm]

Hey team! Please add your planning poker estimate with Zenhub @dantecatalfamo @jacobshandling @lucasmrod @sgress454

[rachaelshaw]

After looking @ this during estimation, decided to bring this to feature fest: looks like the API to get script results is just grabbing the current contents of the script, we don't save a copy of the old script contents. (I think we didn't take this into account when we made scripts editable.)

[noahtalerman]

@rachaelshaw just a reminder that all new feature requests go through unpacking the why ritual before feature fest.

Next can you please add the :product label and move the issue back to "New requests?" That way, Allen and I will pick it up during our next unpacking the why.

[noahtalerman]

@rachaelshaw @sharon-fdm I think we treat this as a bug. It's unexpected behavior. I moved it to "Ready to estimate"

[sharon-fdm]

Please add your planning poker estimate with Zenhub @lucasmrod

[fleet-release]

Script's past and present, Fleet holds in glass city. Clarity restored.