fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Software SS: API Changes

Open georgekarrv opened this issue 1 year ago • 8 comments

  • [ ] #19212
  • [ ] Add self_service to CLI / yaml support https://github.com/fleetdm/fleet/pull/19205
  • Implement Install self-service software API

georgekarrv avatar May 08 '24 14:05 georgekarrv

Hey team! Please add your planning poker estimate with Zenhub @dantecatalfamo @ghernandez345 @gillespi314 @jahzielv @mna @roperzh

georgekarrv avatar May 08 '24 16:05 georgekarrv

Quick thought: we probably need the self_service boolean in both the software_installers table (so we know it allows self-service), but also in host_software_installs if we need to know that the install request was via self-service (vs by the admin). E.g. if we want to add that "was via self-service" in the activity.

mna avatar May 08 '24 16:05 mna

@georgekarrv What do you mean by the Install self-service software API?

dantecatalfamo avatar May 17 '24 20:05 dantecatalfamo

https://github.com/fleetdm/fleet/pull/18507/files#diff-831a63ebb3cab9b4e6b82d803d9ffcdc3722b12d486dcd7b13e9576643bb50b0R2486

where it queue's up the install for that device

and is a device token auth'd endpoint

georgekarrv avatar May 17 '24 20:05 georgekarrv

Do we want self-service to be indicated in the "installer added" activity feed?

dantecatalfamo avatar May 21 '24 20:05 dantecatalfamo

I assume yes and added it

dantecatalfamo avatar May 21 '24 20:05 dantecatalfamo

@marko-lisica Heads-up the figma for the CLI seems wrong for the self-service, it shows query and script as sub-fields of the pre-install and post-install sections (and no sub-field for the install section), but that's not what we went with for the Software Installers story - all sub-fields of install_script, pre_install_query and post_install_script are path.

The (wrong) figma for self-service: https://www.figma.com/design/Bbj4hgj84iYnGeoTpxetLo/%2317587-Software-self-service?node-id=386-4053&t=sAyh99jAWDGKKp3C-0

The (right) figma for software installers (how it is currently implemented): https://www.figma.com/design/oQl2oQUG0iRkUy0YOxc307/%2314921-Deploy-security-agents-to-macOS%2C-Windows%2C-and-Linux-hosts?node-id=820-14313&t=VedSlwV45RyLf087-0

I'll assume it is a mistake in the figma and will just add the self_service field for this ticket.

mna avatar May 22 '24 14:05 mna

I'll assume it is a mistake in the figma and will just add the self_service field for this ticket.

@mna That's right. It's my mistake, will update now.

marko-lisica avatar May 22 '24 16:05 marko-lisica

API changes bloom, Like clouds part in glass city, Ease in service blooms.

fleet-release avatar Jun 10 '24 17:06 fleet-release