fleet icon indicating copy to clipboard operation
fleet copied to clipboard
verified publisher icon fleetdm

API design: Deploy security agents to macOS, Windows, and Linux hosts

Open marko-lisica opened this issue 1 year ago • 5 comments

API design for:

  • #14921

marko-lisica avatar Mar 26 '24 17:03 marko-lisica

This doesn't really make sense to include in the examples, but: the host software API should include "browser" as well when the source is a browser extension (used to display "Browser plugin (<browser>)" as the software type). I think this is currently implemented on the software list page but we forgot to bring that change into the host-specific software page.

rachaelshaw avatar Apr 11 '24 22:04 rachaelshaw

This doesn't really make sense to include in the examples, but: the host software API should include "browser" as well when the source is a browser extension (used to display "Browser plugin ()" as the software type). I think this is currently implemented on the software list page but we forgot to bring that change into the host-specific software page.

@rachaelshaw I think what we want with this new endpoint is to display software titles per host (all installed software titles, no matter what type), plus we're adding status and install action. Do you think that's not clear from the wireframes, should we add dev note or note to issue description?

marko-lisica avatar Apr 12 '24 12:04 marko-lisica

I think what we want with this new endpoint is to display software titles per host (all installed software titles, no matter what type)

@marko-lisica I think that's clear; just wanted to make sure we also bring in the change from https://github.com/fleetdm/fleet/issues/15429 to include browser in the API when applicable; it doesn't apply to the examples in this PR so didn't make sense to mention in a review comment. (Sorry, should have linked to the issue in my previous comment to make that clearer.)

rachaelshaw avatar Apr 12 '24 18:04 rachaelshaw

@marko-lisica, draft docs are missing the changes for the new software_status query param on the list hosts API

gillespi314 avatar May 02 '24 18:05 gillespi314

@marko-lisica, draft docs are missing the changes for the new software_status query param on the list hosts API

@gillespi314 Added this here.

marko-lisica avatar May 09 '24 20:05 marko-lisica

Hey @rachaelshaw when you get the chance, can you please give this a final review?

We're targeting shipping the Deploy security agents story today.

Thanks!

noahtalerman avatar May 23 '24 18:05 noahtalerman

@marko-lisica @noahtalerman just realized: should we open a fresh PR from this branch? (Looks like this one has been open since March.)

rachaelshaw avatar May 23 '24 20:05 rachaelshaw

Ah, makes sense. Heads up @marko-lisica. This is so we don't muck w/ the PR open time KPI.

From the handbook: Screenshot 2024-05-23 at 4 30 34 PM

Here's a short Loom I recorded on how to open a new PR from an existing branch using the GitHub UI.

noahtalerman avatar May 23 '24 20:05 noahtalerman