fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Fix wrong number of host in mdm solutions modal and fix mdm solutions table UI to for null named solutions

Open ghernandez345 opened this issue 1 year ago • 1 comments

relates to #16837, #17334, #17335

This fixes a UI bug for the case where the mdm solution name can be null. We now handle this case properly and show the mdm solution data in the modal.

This also fixes a UI bug where we showed the incorrect number of hosts in the mdm solutions modal.

There is various cleanup here to the js and scss code in this PR too.

  • [x] Added/updated tests
  • [x] Manual QA for all new/changed functionality

ghernandez345 avatar Mar 04 '24 15:03 ghernandez345

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.48%. Comparing base (2d1caa8) to head (7ae4041).

:exclamation: Current head 7ae4041 differs from pull request most recent head 1ad058f. Consider uploading reports for the commit 1ad058f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17336   +/-   ##
=======================================
  Coverage   65.48%   65.48%           
=======================================
  Files        1190     1190           
  Lines      106956   106958    +2     
  Branches     2569     2572    +3     
=======================================
+ Hits        70039    70041    +2     
  Misses      31581    31581           
  Partials     5336     5336           
Flag Coverage Δ
frontend 52.05% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 04 '24 15:03 codecov[bot]

@gillespi314 I'll make another PR to address your comments so I can get this fix in before freeze. Thanks for the review!

ghernandez345 avatar Mar 05 '24 11:03 ghernandez345