fleet icon indicating copy to clipboard operation
fleet copied to clipboard

[Fleet UI] Search bar does not disregard leading and trailing spaces.

Open ksatter opened this issue 1 year ago • 1 comments

Fleet version: v4.44.0 Web browser and operating system:


💥  Actual behavior

When using the search bar in the Fleet UI, I do not see results if there is a space at the beginning of my search term.

If I search for my host in Fleet using 'kath', I see results:

image

But ' kath' and 'kath ' do not return results

image

This also applies when searching by CVE in Software, as well as searching Queries or Policies by name.

🧑‍💻  Steps to reproduce

In Dogfood:

  1. Search hosts using 'kath', ' kath', and 'kath '
  2. Search Policies for the Workstations team using 'lin', ' lin' and 'lin '
  3. Search Queries for the Workstations team using 'col', ' col', and 'col '
  4. Search Software for the Workstations team using '523', ' 523' and '523 '

🕯️ More info (optional)

N/A

ksatter avatar Feb 06 '24 00:02 ksatter

Discussion with the team:We will remove leading and ending spaces assuming no host or CVE has them. We will also trim spaces for policies and queries.

To be clear on the scope: Only trim on the search (no trim on creating anything)

@rachaelshaw if good, NP. else take to product.

sharon-fdm avatar Feb 21 '24 19:02 sharon-fdm

Adding 3 points at sprint kickoff to account for wide-reaching integration test coverage requirement

jacobshandling avatar Mar 11 '24 18:03 jacobshandling

@jacobshandling Please note that as per the new process we need to merge into the patch branch patch-fleet-v4.47.1

sharon-fdm avatar Mar 13 '24 19:03 sharon-fdm

Spaces at the start and end, Like dewdrops, gently swept away. Fleet's search, now more friend.

fleet-release avatar Apr 17 '24 00:04 fleet-release