flatpak-builder icon indicating copy to clipboard operation
flatpak-builder copied to clipboard
verified publisher icon flatpak

Run shell before the start of the build

Open koko-ng opened this issue 3 years ago • 3 comments

Hi :) For some build systems there were calls to build before shell, which made it impossible to open a shell in the build environment if the build failed. I don't think that moving shell before has an implication on the environment as the code in between only seems to do checks on the project.

Fixes #479

koko-ng avatar Jan 02 '23 17:01 koko-ng

It does change the behavior since previously it would configure the project, then open a shell, now it just opens a shell.

I'm not sure this distinction matters or not but another possibility is if run_shell is TRUE to not consider configuration failures as fatal?

TingPing avatar Jan 03 '23 01:01 TingPing

I'm not sure this distinction matters or not but another possibility is if run_shell is TRUE to not consider configuration failures as fatal?

Yes please, otherwise how am I suppose to debug a module that fails in configure step? if I'm not able to open a shell in that case..

nbenitez avatar Nov 19 '24 17:11 nbenitez

This sounds like the better fix to me https://github.com/flatpak/flatpak-builder/pull/625#issuecomment-3418428925

You opened the PR from your main branch and I can't rebase it, @koko-ng can you rebase this?

bbhtt avatar Oct 18 '25 13:10 bbhtt