flatpak-builder-tools icon indicating copy to clipboard operation
flatpak-builder-tools copied to clipboard

flatpak-node-generator does not work well with lockfile v3 in monorepo

Open G-Ray opened this issue 2 years ago • 7 comments

flatpak-builder version

1.3.3

Linux distribution and version

Fedora 38

Affected flatpak-builder tool

node/flatpak-node-generator.py

flatpak-builder tool cli args

No response

Source repository URL

https://github.com/G-Ray/pikatorrent

Flatpak-builder manifest URL

https://github.com/G-Ray/flathub/blob/pikatorrent-build-from-sources/com.github.G_Ray.pikatorrent.yml

Description

Trying to generate sources with flatpak-node-generator npm ./package-lock.json (lockfile v3) in a monorepo project results in only a few dependencies written.

example with https://github.com/G-Ray/pikatorrent:

3957 packages read.
Generating packages [3957/3957] randombytes @ 2.1.0                                                     
Wrote 226 source(s)

Meanwhile, if I convert the lockfile to v2:

1983 packages read.
Generating packages [1983/1983] @tamagui/label @ 1.55.2                                                 
Wrote 6968 source(s)

G-Ray avatar Aug 30 '23 20:08 G-Ray

This is confirmed. Regenerating a v2 lockfile with npm i --lockfile-version 2 --package-lock-only helped for all dependencies to be included.

almereyda avatar Apr 10 '24 01:04 almereyda