nebraska icon indicating copy to clipboard operation
nebraska copied to clipboard

helm chart: Add extra labels and annotations to pods and k8s resources / Allow SSL mode to be defined.

Open jescarri opened this issue 2 years ago • 7 comments

Allow users to specify extra labels and annotations to pods and other k8s resources.

This change allows users to set extra labels and annotations to pods and k8s resources.

How to use

In the values file:

extraLabels:
  foo: bar
 extraAnnotations:
  foo: bar

podLabels:
  another: test
podAnnotations:
   test: test

The above will label all k8s resources with foo: bar and annotate all k8s resources with foo:bar

In addition pods will be labelled with extraLabels + another: test and annotated with extraAnnotations + test: test

To test:

Deploy nebraska using the helm chart + add the above values to your values file.

Testing done

Nebraska has been deployed in our clusters using the modified helm chart, we are able to add extra labels and annotations.

  • [ *] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • [ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

jescarri avatar Jun 23 '23 19:06 jescarri

Sorry for the review delay, we'll try to assign someone in tomorrow's planning call https://github.com/flatcar/Flatcar/discussions/1103

pothos avatar Jul 24 '23 08:07 pothos

Ah! sweet let me bump the version.

Thanks!

jescarri avatar Jul 24 '23 16:07 jescarri

@pothos bumped the patch version.

Thanks for taking a look at this PR.

jescarri avatar Jul 24 '23 17:07 jescarri

At my company we would really like this change as well.

efcy avatar Jul 31 '23 13:07 efcy

The CI linter complains, can someone have a look? I used the GitHub UI to bump to version 1.1.1 but it created a merge commit, maybe squash that, too.

pothos avatar Jul 31 '23 16:07 pothos

Cool I will add the fixes today.

Thanks for the review.

jescarri avatar Jul 31 '23 18:07 jescarri

hi @jescarri, friendly ping here, Did you get to look through the suggestions mentioned in the review?

sayanchowdhury avatar Aug 21 '23 12:08 sayanchowdhury

Closing in favor of #1097

ervcz avatar Jul 14 '25 11:07 ervcz