framework icon indicating copy to clipboard operation
framework copied to clipboard
verified publisher icon flarum

[Subscriptions] New post email notification showing "unknown" when replying directly to someone or mentioning them.

Open orschiro opened this issue 4 years ago • 9 comments

Example:

image

Related to: https://github.com/flarum/mentions/pull/71#issuecomment-1029804973

Happened to me on Flarum 1.2.0.

orschiro avatar Feb 04 '22 16:02 orschiro

can reproduce

SychO9 avatar Jun 09 '22 10:06 SychO9

@orschiro can you still reproduce this in v1.5 ? I can't reproduce anymore.

SychO9 avatar Oct 02 '22 10:10 SychO9

@SychO9 yes, it's still happening for me on v1.5. See below example.

image

image

orschiro avatar Oct 02 '22 18:10 orschiro

@SychO9 this relates to notifications generated via flarum/subscriptions, rather than the regular flarum/mentions notification.

I've just replicated with 1.6-dev:

[2022-11-05 08:12:22] flarum.INFO: Message-ID: <[email protected]>
Date: Sat, 05 Nov 2022 08:12:22 +0000
Subject: [New Post] test
From: Flarum Dev Docker <noreply@localhost>
To: admin <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hey admin!

Lowerclass-Order made a post in a discussion you're following: test.

To view the new activity, check out the following link:
https://dev.morland.it/d/11/11

---

hey @"[deleted]"#1 

---

You won't receive any more notifications about this discussion until you're up-to-date.

  
[2022-11-05 08:28:42] flarum.INFO: Message-ID: <[email protected]>
Date: Sat, 05 Nov 2022 08:28:42 +0000
Subject: [New Post] test
From: Flarum Dev Docker <noreply@localhost>
To: admin <[email protected]>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hey admin!

Lowerclass-Order made a post in a discussion you're following: test.

To view the new activity, check out the following link:
https://dev.morland.it/d/11/12

---

@"[unknown]"#p236 hi

---

You won't receive any more notifications about this discussion until you're up-to-date.

imorland avatar Nov 05 '22 08:11 imorland

Extension load order also has an impact here.

  • mentions before subscriptions = no notification
  • subscriptions before mentions = notification, but with deleted/unknown rendered for the user/post mention.

I assume the upcoming GroupMention and TagMention would also be impacted by this too

imorland avatar Nov 05 '22 09:11 imorland