JSNetworkX icon indicating copy to clipboard operation
JSNetworkX copied to clipboard

Updating dependencies

Open albertossilva opened this issue 6 years ago • 7 comments

albertossilva avatar Jul 23 '19 06:07 albertossilva

The main reason for this upgrade is npm audit. Now it has 0 vulnerabilties

albertossilva avatar Jul 23 '19 06:07 albertossilva

Feels good to me. Maybe I can use it instead the original one.

njzjz avatar Sep 22 '19 04:09 njzjz

Using your code with webpack, I catch the error Uncaught ReferenceError: regeneratorRuntime is not defined. What's wrong?

njzjz avatar Sep 22 '19 23:09 njzjz

Using your code with webpack, I catch the error Uncaught ReferenceError: regeneratorRuntime is not defined. What's wrong?

The problem is fixed by installing and importing regenerator-runtime.

njzjz avatar Nov 09 '19 05:11 njzjz

So... @njzjz, should I install and add this dependency to my branch as well?

albertossilva avatar Dec 09 '19 07:12 albertossilva

So... @njzjz, should I install and add this dependency to my branch as well?

I add the following before import jsnetworkx:

global.regeneratorRuntime = require("regenerator-runtime");

and it works.

njzjz avatar Dec 09 '19 16:12 njzjz

So.. it makes sense to add on the documentation, that this library is required when used in webpack.

On Mon, Dec 9, 2019, 17:28 Jinzhe Zeng [email protected] wrote:

So... @njzjz https://github.com/njzjz, should I install and add this dependency to my branch as well?

I add the following before import jsnetworkx:

global.regeneratorRuntime = require("regenerator-runtime");

and it works.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fkling/JSNetworkX/pull/85?email_source=notifications&email_token=AAFPFYLG2XYGQMCOZLB5QSDQXZWZVA5CNFSM4IGAJMZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJZBHQ#issuecomment-563318942, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFPFYI2C7OXLR56D35FZJDQXZWZVANCNFSM4IGAJMZA .

albertossilva avatar Dec 09 '19 20:12 albertossilva

Won't do

albertossilva avatar Dec 29 '23 11:12 albertossilva