http-api-data icon indicating copy to clipboard operation
http-api-data copied to clipboard

Allow cookie-0.5

Open spencerjanssen opened this issue 1 year ago • 6 comments

spencerjanssen avatar Apr 29 '24 21:04 spencerjanssen

The changelog for cookie-0.5 says

This is a breaking change, as it changes the behavior of parseCookies and parseSetCookie to no longer include the surrounding double quotes in the cookie value. This is the correct behavior according to the RFC.

And we do use parseSetCookie. Have you verified that things still work?

phadej avatar Apr 30 '24 04:04 phadej

I did run the test suite, yes. Reasonable uses of the API provided by cookie or http-api-data will not break. According to the RFC user agents may optionally wrap the cookie value in double quotes.

I think we are also covered by the disclaimer attached to the instances for SetCookie:

/Note:/ this instance works correctly for alphanumeric name and value

I can add a note about this in the changelog if you'd like.

spencerjanssen avatar Apr 30 '24 11:04 spencerjanssen

Yes, I think it's better to do a separate release for this, i.e. not just a "silent" Hackage revision.

phadej avatar Apr 30 '24 11:04 phadej

Sounds good. I can add a changelog entry. Shall I include a minor version bump up to 0.6.1 as well?

spencerjanssen avatar Apr 30 '24 11:04 spencerjanssen

Shall I include a minor version bump up to 0.6.1 as well?

Please do.

phadej avatar Apr 30 '24 11:04 phadej

Done, thanks for the review!

spencerjanssen avatar Apr 30 '24 14:04 spencerjanssen