fishjam icon indicating copy to clipboard operation
fishjam copied to clipboard

Feat/introduce ADRs

Open kamciokodzi opened this issue 1 year ago • 1 comments

Acknowledging the stipulations set forth:

  • [ ] I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
  • [ ] I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

kamciokodzi avatar May 17 '24 14:05 kamciokodzi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.92%. Comparing base (465ae81) to head (aaefe0e). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   87.32%   86.92%   -0.40%     
==========================================
  Files          74       74              
  Lines        1530     1530              
==========================================
- Hits         1336     1330       -6     
- Misses        194      200       +6     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 465ae81...aaefe0e. Read the comment docs.

codecov[bot] avatar May 17 '24 14:05 codecov[bot]

Awesome, I added a few minor comments 👍 Also, what are we going to do with the old design docs? Maybe create a new directory for them called old?

Well I assumed here that we won't write ADRs for old decisions. I wouldn't also call them old since they are up to date with the current architecture. I don't mind having them laying around in the docs folder, but I'm open to suggestions.

kamciokodzi avatar May 20 '24 07:05 kamciokodzi