react-three-renderer icon indicating copy to clipboard operation
react-three-renderer copied to clipboard
verified publisher icon firtoz

Updated `matrix.copy` to `applyMatrix`

Open dkozma opened this issue 9 years ago • 2 comments

When trying to pass in a Matrix4 via the matrix prop, it seemed that my Object3D wasn't applying it at all. After updating it to use applyMatrix, the matrix transformation seemed to work fine.

dkozma avatar Mar 28 '17 18:03 dkozma

@toxicFork I submitted this pull request, however I saw that the old code used this function and then it was changed in January with this commit: https://github.com/toxicFork/react-three-renderer/commit/81142f8bbc17fd3d7509ba772814215da7f20765#diff-77134061d2e13d41e19e16ed94cf8cf6

Is there a reason this was changed from applyMatrix to the copy/decompose method? The latter doesn't work for me, hence the need for this PR.

Thanks!

dkozma avatar Mar 30 '17 16:03 dkozma

I still need to investigate this (sorry about taking so long)

toxicFork avatar Nov 10 '17 09:11 toxicFork