firstcontributions.github.io icon indicating copy to clipboard operation
firstcontributions.github.io copied to clipboard

Migration to Next.js

Open AugustinMauroy opened this issue 2 years ago • 12 comments

🐞 Problem

Simple CRA it's difficult to maintain.

🎯 Goal

Add this feat:

  • next.js meta framwork
  • typescript support
  • sass support
  • unit test for components

📋 Steps to solve the problem

  • First pr to migrate
  • Seconde to add Linter like ES-lint
  • Third pr for sass
  • add unit test

AugustinMauroy avatar Feb 26 '23 22:02 AugustinMauroy

Hey bro, it's sounds pretty good~😊 But this repository seems no one maintain any more I think Maybe you're doing this now...❤️

izkizk8 avatar Mar 03 '23 16:03 izkizk8

CC @Roshanjossey

AugustinMauroy avatar Mar 03 '23 17:03 AugustinMauroy

Is this project still alive I can help you guys on migrating to nextjs

mirsahib avatar Jul 04 '23 19:07 mirsahib

Hey @AugustinMauroy ,

I'm a little curious about this issue and wanted to check if there has been any progress or if any initial steps have been taken to address it.

I have a suggestion that could take the project to the next level. Have you considered using a framework like Next.js, similar to Docasaurus? It's incredibly user-friendly, and practical, and can provide a lot of helpful features.

I'd love to hear your thoughts on this idea. Let me know what you think!

Esh07 avatar Jul 18 '23 16:07 Esh07

@Esh07

  1. We wait maintainer validation (And I’m waiting for write acces)
  2. For using daucosorus, I’m not fan because it’s less flexible. And for i18n it’s become complicated on infrastructure pov Thanks for your interest sorry for the strange message I’m on phone because I’m not at home

AugustinMauroy avatar Jul 19 '23 00:07 AugustinMauroy

For using daucosorus, I’m not fan because it’s less flexible. And for i18n it’s become complicated on infrastructure pov Thanks for your interest.

Oh, okay. I believe it’s quite simple. Docusaurus is flexible in terms of implementing small documentation like we have on the first-contribution repository. It also has features for implementing blogs and we can make a separate page for listing projects. On top of that, it makes things even easier with GitHub integration for CI/CD, unit testing, and more.

From my experience, I find it easy to use because you don’t have to worry about handling routing. They’ve made it simple to manage. And I think for this repository, it’s enough.

In terms of infrastructure, we can even make smaller fragments of docs to manage each file, which makes life easier for maintainers and reviewers.

And even Docusaursdoes does provide a solution for i18n.

This is my thought and suggestion.

However, 😊 I am open to further discussion and welcome any ideas.

Esh07 avatar Jul 19 '23 12:07 Esh07

This app loads data about projects from a json file and renders it.

What does it need Typescript and SASS support for? What architectural problem is fixed by using Nextjs?

Simple CRA it's difficult to maintain.

How does this statement apply to this app?

Roshanjossey avatar Jul 21 '23 16:07 Roshanjossey

hey !

How does this statement apply to this app?

In general Nextjs app is more easy to maintain than CRA.

Also use nextjs increase DX. And simplify coding. So it's allow more poeple to contribue.

Other point, we can i18n website esalier.

to continue we will have an better SEO

AugustinMauroy avatar Jul 30 '23 12:07 AugustinMauroy

Not in general, specific to this project.

When you have a hammer, everything might look like a nail. We should be wise to use right tools for respective scenarios.

I like Nextjs a lot. For the last 3 years, I have preferred it over CRA. Think about it this way. What features of Next does this app need that CRA is not doing now? Does it need routing? api functions? ISR?

increase DX. And simplify coding. So it's allow more poeple to contribue.

This is a generic statement that can be said about a lot of things. Like for Docker or Kubernetes But does this project need any of that?

Do the benefits of such a refactor justify the effort of people doing it? Maintainers reviewing the changes?

Roshanjossey avatar Jul 30 '23 18:07 Roshanjossey

you should take a look to this draft to have an better understanding

AugustinMauroy avatar Jul 30 '23 19:07 AugustinMauroy

Doesn't answer any of the questions @AugustinMauroy. Question is not if we can do it. It's if we should do it

Roshanjossey avatar Jul 31 '23 08:07 Roshanjossey

Do the benefits of such a refactor justify the effort of people doing it? Maintainers reviewing the changes?

Yeah I'm 100% sure.

But does this project need any of that?

As I said above, I think so. Thanks to nextjs lots of possibilities are opening up. Like i18n, several pages that give advice (which would be written in markdown/mdx)

AugustinMauroy avatar Jul 31 '23 08:07 AugustinMauroy