fds icon indicating copy to clipboard operation
fds copied to clipboard

Global pressure solvers do not consider DEVC activation of OBST

Open rmcdermo opened this issue 4 years ago • 3 comments

Here is a simple test case to demonstrate that the global solvers (UGLMAT, ULMAT, USCARC) all need to consider OBST time activation, as this is an often used feature in FDS.

test.fds.txt

rmcdermo avatar Jan 25 '22 16:01 rmcdermo

I‘ll have a look

Am 25.01.2022 um 17:20 schrieb Randy McDermott @.***>:



Assigned #10271https://github.com/firemodels/fds/issues/10271 to @SusanKilianhttps://github.com/SusanKilian.

— Reply to this email directly, view it on GitHubhttps://github.com/firemodels/fds/issues/10271#event-5951134342, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYYOFPHADZTFAN5OSBWJNDUX3EUPANCNFSM5MYWTRAQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.Message ID: @.***>

SusanKilian avatar Jan 25 '22 17:01 SusanKilian

In addition to the OBST activation, we need to make sure that the LEAK model works when an opening or closing of a zone occurs. The test cases to look at here are the zone_break cases in fds/Verification/Pressure_Effects. When I try the latest USCARC on theses cases, I get a seg fault.

zone_break_fast_usarc.fds.txt

Follow the logic of MERGE_PRESSURE_ZONES in divg.f90. I think all the global solvers need to address this.

rmcdermo avatar Mar 11 '22 19:03 rmcdermo

Okay, I will work from here and also look at the LEAK zone model ...

SusanKilian avatar Mar 14 '22 08:03 SusanKilian