profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Create a sharing workflow for profile sharing on Android

Open canova opened this issue 3 years ago • 5 comments

Previously we only had remote profiling for Android, but now we have profile capturing directly from Fenix as well. The profile capturing workflow there consists of capturing the profile data and sharing it immediately so user can have a link that they can share. We show a warning saying that the profile may include PII, but we don't have the ability to share a profile with some PII removed (like our sharing panel).

We should be able to open profiler.firefox.com with the profile on Fenix as well and show a simplified sharing workflow. This can be a simple web page that consists only of the sharing panel. That way, user can select what they would like to include to the profile and what they would like to remove. We could create another url for this workflow like profiler.firefox.com/share or profiler.firefox.com/mobile-share

┆Issue is synchronized with this Jira Task

canova avatar Jun 10 '22 10:06 canova

Could the "simple web page" be in-tree instead of something inside profiler.firefox.com? If we don't expect it to change regularly, this could be better.

julienw avatar Jun 14 '22 13:06 julienw

Possibly, yes. But I feel like this will cause us to duplicate some code and we'll have to maintain them in two separate places. Currently, I think we can make this work by reusing our sharing popup with some modifications. This will automatically bring the sanitization features that we need. If we need to put it inside Fenix instead, we'll have to duplicate the sanitization code. Which means that whenever we touch the sanitization (e.g. new data added that need to be sanitized), we need to update two places.

canova avatar Jun 14 '22 13:06 canova

They are good arguments in favor of having this in the main product indeed, thanks!

julienw avatar Jun 14 '22 13:06 julienw