profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Marker Chart: Allow sorting, e.g., by first marker start time, etc.

Open squelart opened this issue 5 years ago • 2 comments

The marker chart is sorted by categories A-Z and then type A-Z. This is nice and predictable, but it means it can be a bit difficult to see the order of things, and we have markers like "FirstNonBlankPaint" after "FirstContentfulPaint" though their actual time order is always the reverse.

I think it would be useful to allow re-ordering in different ways:

  • Sort by first marker start time and then shortest duration.
  • Sort by first marker end time and then shortest duration.
  • Enable/disable category grouping.
  • Drag individual rows -- The user may be interested in comparing specific markers in different categories and types.
  • Drag individual markers(!), this would effectively split rows. Less sure of the usefulness, maybe instead we could add time bars in the Marker Table view.
  • Something like the Stack Chart view where Auto markers (those generated through AUTO_PROFILER_MARKER_...) could build pyramids of nested markers. 0-duration markers could be leaves. And optionally other markers could be added if they "play nice" with their potential nested parent/children, the rest can be added below the chart.

┆Issue is synchronized with this Jira Task

squelart avatar May 07 '20 00:05 squelart

Duration and start time based sorting are implemented in #4203.

You're other requests seem to be harder to implement in more difficult to comprehend.

parttimenerd avatar Aug 28 '22 07:08 parttimenerd

Duration and start time based sorting are implemented in #4203.

You're other requests seem to be harder to implement in more difficult to comprehend.

Note that this bug is about the marker chart, not the marker table :-)

julienw avatar Aug 29 '22 15:08 julienw