firedancer icon indicating copy to clipboard operation
firedancer copied to clipboard

fix typo: fd_ext_bank_sanitized_txn_load_addresess

Open sonicfromnewyoke opened this issue 1 year ago • 4 comments

closes #2642

sonicfromnewyoke avatar Oct 23 '24 13:10 sonicfromnewyoke

This function is part of the Rust FFI in our Agave patch https://github.com/firedancer-io/agave/blob/v1.18.25-fd/runtime/src/bank.rs#L315

two-heart avatar Oct 23 '24 14:10 two-heart

This function is part of the Rust FFI in our Agave patch https://github.com/firedancer-io/agave/blob/v1.18.25-fd/runtime/src/bank.rs#L315

my bad... made a PR in the Agave patch

sonicfromnewyoke avatar Oct 23 '24 17:10 sonicfromnewyoke

Sorry! The workflow for the Agave branch is a bit convoluted ... but designed to keep the Agave patches clean and easily rebased. In this case...

You will need to update the Agave side, then rebase those changes into whatever commit in the Agave commit stack added the typo. Then push this rebased Agave to any branch (e.g. sonicfromnewyoke/typo). Then change the Firedancer side to point to that Agave commit (git add agave from firedancer repo), then push that change as a PR to this repo.

mmcgee-jump avatar Oct 25 '24 04:10 mmcgee-jump

@mmcgee-jump Yeah, it's a little bit tricky. Would you mind if I added this contribution flow to the CONTRIBUTING.md?

and, if I understood correctly, to push agave-submodule I (and any other newcomer) need permissions for that?

sonicfromnewyoke avatar Oct 25 '24 10:10 sonicfromnewyoke

This code no longer exists

mmcgee-jump avatar Nov 14 '24 18:11 mmcgee-jump