firedancer icon indicating copy to clipboard operation
firedancer copied to clipboard

support https in snapshot loader

Open lidatong opened this issue 1 year ago • 2 comments

lidatong avatar Jun 23 '24 22:06 lidatong

To add some context, we'll need to download snapshots over HTTPS.

@mmcgee-jump For this one, I suggest dynamically linking libssl via dlopen. What do you think?

libssl is typically tightly integrated with the OS (CA certs, etc) and is not guaranteed to be OpenSSL. Other benefits of not statically linking are not having to include the OpenSSL release lifecycle into Firedancer and a leaner binary size (less gadgets, etc). So, we'd just vendors the headers and try to load an OpenSSL at runtime into the snapshot tiles. If it fails, we can gracefully error out.

ripatel-fd avatar Jun 23 '24 22:06 ripatel-fd

Best to just statically link OpenSSL IMO

mmcgee-jump avatar Jun 24 '24 04:06 mmcgee-jump