firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

chore(docs): deprecate --start-time-cpu-us parameter

Open pb8o opened this issue 2 years ago • 1 comments

Changes

Deprecate the --start-time-cpu-us parameter.

Reason

It is always 0 so it does not provide any useful information.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • [ ] All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • [ ] Commits meet contribution quality standards.

  • [x] This functionality cannot be added in rust-vmm.

pb8o avatar Jan 11 '24 15:01 pb8o

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b546bc5) 81.63% compared to head (d13d31e) 81.63%.

Files Patch % Lines
src/firecracker/src/main.rs 0.00% 1 Missing :warning:
src/jailer/src/env.rs 50.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4358   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files         243      243           
  Lines       29800    29789   -11     
=======================================
- Hits        24326    24319    -7     
+ Misses       5474     5470    -4     
Flag Coverage Δ
4.14-c5n.metal 78.95% <80.00%> (+<0.01%) :arrow_up:
4.14-c7g.metal ?
4.14-m5d.metal ?
4.14-m5n.metal 78.94% <80.00%> (+<0.01%) :arrow_up:
4.14-m6a.metal 78.08% <80.00%> (+<0.01%) :arrow_up:
4.14-m6g.metal 77.03% <80.00%> (+<0.01%) :arrow_up:
4.14-m6i.metal 78.94% <80.00%> (+<0.01%) :arrow_up:
4.14-m7g.metal 77.03% <80.00%> (+<0.01%) :arrow_up:
5.10-c5n.metal 81.61% <80.00%> (+<0.01%) :arrow_up:
5.10-c7g.metal ?
5.10-m5d.metal ?
5.10-m5n.metal 81.60% <80.00%> (+<0.01%) :arrow_up:
5.10-m6a.metal 80.83% <80.00%> (+<0.01%) :arrow_up:
5.10-m6g.metal 79.92% <80.00%> (+<0.01%) :arrow_up:
5.10-m6i.metal 81.59% <80.00%> (+<0.01%) :arrow_up:
5.10-m7g.metal 79.92% <80.00%> (+<0.01%) :arrow_up:
6.1-c5n.metal 81.61% <80.00%> (+<0.01%) :arrow_up:
6.1-c7g.metal ?
6.1-m5d.metal ?
6.1-m5n.metal 81.60% <80.00%> (+<0.01%) :arrow_up:
6.1-m6a.metal 80.83% <80.00%> (+<0.01%) :arrow_up:
6.1-m6g.metal 79.92% <80.00%> (+<0.01%) :arrow_up:
6.1-m6i.metal 81.59% <80.00%> (+<0.01%) :arrow_up:
6.1-m7g.metal 79.92% <80.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 14:01 codecov[bot]