firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard
verified publisher icon firecracker-microvm

Acpi poweroff feature

Open andreitraistaru opened this issue 3 years ago • 1 comments

Reason for This PR

Support for ACPI shutdown added in Firecracker.

Description of Changes

In order to implement a graceful shutdown of the guest, two features were implemented:

  1. Send ACPI signal to the guest using fixed hardware method (according to the spec) when HTTP request is received by the API thread
  2. Detection of the guest's transition to soft-off state (S5) in order to stop Firecracker process gracefully
  • [ ] This functionality can be added in rust-vmm.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PR Checklist

  • [ ] All commits in this PR are signed (git commit -s).
  • [ ] The issue which led to this PR has a clear conclusion.
  • [ ] This PR follows the solution outlined in the related issue.
  • [ ] The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this PR.
  • [ ] Any newly added unsafe code is properly documented.
  • [ ] Any API changes follow the Runbook for Firecracker API changes.
  • [ ] Any user-facing changes are mentioned in CHANGELOG.md.
  • [ ] All added/changed functionality is tested.

andreitraistaru avatar Mar 14 '22 12:03 andreitraistaru

Thank you so much for the comments you left above! I'll take each of them and improve the code accordingly!

andreitraistaru avatar Mar 15 '22 08:03 andreitraistaru

Closing this in favor of https://github.com/firecracker-microvm/firecracker/pull/3190

andreitraistaru avatar Feb 28 '23 09:02 andreitraistaru