firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Replace fixture generation through exec() with a cleaner method

Open gbionescu opened this issue 5 years ago • 1 comments

Currently, image fixtures are built by enumerating capabilities in the S3 bucket and calling exec() to create new fixtures.

It would be much cleaner to have a list of images inside the test framework that generates the fixtures for us.

Documentation will also have to be updated: https://github.com/firecracker-microvm/firecracker/blob/41c9cdb00d1061b6f7a67b0cf754edd2ebdd069c/tests/README.md#adding-microvm-images

gbionescu avatar Nov 23 '20 17:11 gbionescu

Happy to help on the issue.

kumargu avatar Nov 23 '20 17:11 kumargu

This will be fixed by #3896

roypat avatar Jul 25 '23 15:07 roypat

Above PR has been merged. With the new CI artifacts, we no longer generate fixtures through exec

roypat avatar Aug 24 '23 10:08 roypat