keepmenu icon indicating copy to clipboard operation
keepmenu copied to clipboard
verified publisher icon firecat53

add support for keeotp & keepass2 otp fields

Open bdeshi opened this issue 3 years ago • 2 comments

closes #117

TODO

  • [x] support keeotp's key=... style otp field
  • [x] support keepass2's totp fields
  • [x] add tests

bdeshi avatar Jul 25 '22 05:07 bdeshi

@firecat53 keepmenu currently supports only base32 encoded otp seeds, i'm doing the same here. support for additonal encodings may be better implemented in a different subsequent PR. ditto for hotp support. because keepmenu currently assumes all otps are of the totp type.

bdeshi avatar Jul 25 '22 16:07 bdeshi

@firecat53 please review.

bdeshi avatar Jul 27 '22 14:07 bdeshi

Sorry about the delay!! Thanks for the work on this, looks good to me. Do you think there's value in adding documentation to what OTP formats are supported into docs/usage.md? If so, perhaps include some of the links to the documentation that you provided in #117?

If you can rebase on top of the totp branch (I updated my email address recently) after any docs are updated, I'll go ahead and merge this.

Thanks again!

firecat53 avatar Oct 05 '22 00:10 firecat53

@firecat53 how does it look now?

bdeshi avatar Oct 10 '22 07:10 bdeshi

Awesome, thanks so much!

firecat53 avatar Oct 17 '22 14:10 firecat53