functions-samples icon indicating copy to clipboard operation
functions-samples copied to clipboard

Add example code for Performance threshold alert

Open jfcong opened this issue 3 years ago • 2 comments

Add example code for Performance threshold alert for 2nd gen function alert to discord.

jfcong avatar Sep 16 '22 23:09 jfcong

Thanks for the performance sample @jfcong! I'm a bit confused though - how does this PR relate to https://github.com/firebase/functions-samples/pull/1012? Seems like both add the iOS app distro sample. Does it replace that one?

jhuleatt avatar Sep 22 '22 08:09 jhuleatt

Thanks for the performance sample @jfcong! I'm a bit confused though - how does this PR relate to #1012? Seems like both add the iOS app distro sample. Does it replace that one?

@jhuleatt Jenny's PR builds on top of mine (#1011 - I think that's the one you wanted to reference), so it also includes those changes.

You can look at only her changes by selecting only her commits for the diff.

The plan is that I'll first merge my PR, then Jenny will rebase her branch (so it only includes her changes), update this PR, and then merge it.

kaibolay avatar Sep 22 '22 16:09 kaibolay

@jhuleatt Like Kai said, I will rebase once Kai's PR is submitted :)

Thanks Kai for replying!

jfcong avatar Sep 22 '22 17:09 jfcong