flutterfire icon indicating copy to clipboard operation
flutterfire copied to clipboard

feat(remote_config): Added remote_config support for Windows

Open angpysha opened this issue 6 months ago • 5 comments

Description

This PR adds support Firebase Remote Config for Windows

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ ] All existing and new tests are passing.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] The analyzer (melos run analyze) does not report any problems on my PR.
  • [x] I read and followed the Flutter Style Guide.
  • [x] I signed the CLA.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [x] No, this is not a breaking change.

angpysha avatar Jul 14 '25 16:07 angpysha

Thanks for running pipeline. Will fix ASAP

angpysha avatar Jul 17 '25 14:07 angpysha

Hello, I updated my PR, but received analyzer errors regarding packages that I did not change. What should I do in this case? $ melos exec └> dart analyze . --fatal-infos └> FAILED (in 4 packages) └> firebase_ai (with exit code 3) └> firebase_ai_example (with exit code 3) └> firebase_auth (with exit code 3) └> firebase_auth_example (with exit code 3)

angpysha avatar Aug 25 '25 09:08 angpysha

Really appreciate everyone's work on this 👏. Special thanks to @angpysha

isinghmitesh avatar Aug 25 '25 09:08 isinghmitesh

Also I have issues with tests, however if I run tests only on changed packages (firebase_core and firebase_remote_config). They'd completed successfully

Firebase Core
 firebase_core  cd .\firebase_core\                                                                                                                                                                                                
 firebase_core  flutter test                                                                                                                                                                                                       
Resolving dependencies... 
Downloading packages... 
  _fe_analyzer_shared 67.0.0 (88.0.0 available)
  analyzer 6.4.1 (8.1.1 available)
  args 2.6.0 (2.7.0 available)
  build 2.4.1 (3.0.2 available)
  built_value 8.9.2 (8.11.1 available)
  characters 1.4.0 (1.4.1 available)
  code_builder 4.10.0 (4.10.1 available)
  dart_style 2.3.6 (3.1.2 available)
! firebase_core_platform_interface 6.0.0 from path ..\firebase_core_platform_interface (overridden in .\pubspec_overrides.yaml)
! firebase_core_web 3.0.0 from path ..\firebase_core_web (overridden in .\pubspec_overrides.yaml)
  glob 2.1.2 (2.1.3 available)
  material_color_utilities 0.11.1 (0.13.0 available)
  meta 1.16.0 (1.17.0 available)
  mockito 5.4.4 (5.5.0 available)
  package_config 2.1.0 (2.2.0 available)
  pub_semver 2.1.4 (2.2.0 available)
  source_gen 1.5.0 (3.1.0 available)
  test_api 0.7.6 (0.7.7 available)
  vm_service 15.0.0 (15.0.2 available)
  watcher 1.1.0 (1.1.2 available)
  web 1.1.0 (1.1.1 available)
  yaml 3.1.2 (3.1.3 available)
Got dependencies!
20 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Resolving dependencies in `.\example`... 
Downloading packages... 
Got dependencies in `.\example`.
00:07 +3: All tests passed!
Firebase Remote Config
 firebase_remote_config  flutter test                                                                                                                                                                                              
Resolving dependencies... 
Downloading packages... 
  _fe_analyzer_shared 67.0.0 (88.0.0 available)
! _flutterfire_internals 1.3.60 from path ..\..\_flutterfire_internals (overridden in .\pubspec_overrides.yaml)
  analyzer 6.4.1 (8.1.1 available)
  args 2.6.0 (2.7.0 available)
  build 2.4.1 (3.0.2 available)
  built_value 8.9.2 (8.11.1 available)
  characters 1.4.0 (1.4.1 available)
  code_builder 4.10.0 (4.10.1 available)
  dart_style 2.3.6 (3.1.2 available)
! firebase_core 4.0.0 from path ..\..\firebase_core\firebase_core (overridden in .\pubspec_overrides.yaml)
! firebase_core_platform_interface 6.0.0 from path ..\..\firebase_core\firebase_core_platform_interface (overridden in .\pubspec_overrides.yaml)
! firebase_core_web 3.0.0 from path ..\..\firebase_core\firebase_core_web (overridden in .\pubspec_overrides.yaml)
! firebase_remote_config_platform_interface 2.0.1 from path ..\firebase_remote_config_platform_interface (overridden in .\pubspec_overrides.yaml)
! firebase_remote_config_web 1.8.10 from path ..\firebase_remote_config_web (overridden in .\pubspec_overrides.yaml)
  glob 2.1.2 (2.1.3 available)
  material_color_utilities 0.11.1 (0.13.0 available)
  meta 1.16.0 (1.17.0 available)
  mockito 5.4.4 (5.5.0 available)
  package_config 2.1.0 (2.2.0 available)
  pub_semver 2.1.4 (2.2.0 available)
  source_gen 1.5.0 (3.1.0 available)
  test_api 0.7.6 (0.7.7 available)
  vm_service 15.0.0 (15.0.2 available)
  watcher 1.1.0 (1.1.2 available)
  web 1.1.0 (1.1.1 available)
  yaml 3.1.2 (3.1.3 available)
Got dependencies!
20 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Resolving dependencies in `.\example`... 
Downloading packages... 
Got dependencies in `.\example`.
00:07 +17: All tests passed!

angpysha avatar Aug 25 '25 13:08 angpysha

The analyzer (melos run analyze) does not report any problems on my PR. It contains errors that belong to firebase_auth $ melos exec └> dart analyze . --fatal-infos └> FAILED (in 2 packages) └> firebase_auth (with exit code 3) └> firebase_auth_example (with exit code 3)

melos run analyze-ci └> melos exec -c 1 --
dart analyze . --fatal-infos └> FAILED

angpysha avatar Aug 25 '25 13:08 angpysha