firebase
Rename the class "Indentifiers" to "Session"
Rename the class Indentifiers to Session since the class caters to all the necessary details of a session.
This is a precursor to bring in the "Sampling" changes.
#no-changelog
| 1 Warning | |
|---|---|
| :warning: | Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.) |
Generated by :no_entry_sign: Danger
I'm not sure what's the purpose of doing this. I think this name is confusing with other classes such as
SessionsStartEventandFirebaseSessions. I also worry about adding [too much responsibility to 1 class].
Session is a data construct on its own (containing its own attributes like sessionID, previous sessionId, should sample and more) - The current class identifiers is a generic class containing all the identifiers which does not provide separation of concerns.
Session is just the construct - SessionStartEvent is the event that gets dispatched to Firelog. So, they are separate. I don't think that would be confusing.
About FirebaseSessions, I think that would need some renaming, but since it is namespaced with Firebase - I would not be worried as that is how the library is named and it is needed to identify the starting class of the library.