firebase-cpp-sdk icon indicating copy to clipboard operation
firebase-cpp-sdk copied to clipboard

feat: update minimum CMake version to 3.5

Open Lyokone opened this issue 1 year ago • 3 comments

Description

Provide details of the change, and generalize the change in the PR title above.

Updates the CMake version to 3.5. closes #1599


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Manually tested by compiling firebase cpp sdk with FlutterFire.


Type of Change

Place an x the applicable box:

  • [ ] Bug fix. Add the issue # below if applicable.
  • [ ] New feature. A non-breaking change which adds functionality.
  • [X] Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

Lyokone avatar Jun 26 '24 07:06 Lyokone

Do we also want to update the cmake min version for all integration_test within this PR? @jonsimantov

cynthiajoan avatar Jun 27 '24 12:06 cynthiajoan

Hello :) Just wanted to check if there's anything else that needs attention or any next steps on this? Thanks!

KKimj avatar Dec 30 '24 16:12 KKimj

any news here?

Bahrom2101 avatar Feb 02 '25 08:02 Bahrom2101