firebase
Store registered context for sync task unregistrations
For issue #6558, this is an attempt at fixing the IllegalArgumentException by ensuring that the context we use for registering the SyncTask is the same context we use to unregister the task. Race conditions dont seem like a culprit here since unregister is only triggered by the Receiver itself, which should be only executed synchronously on the main thread.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
📝 PRs merging into main branch
Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
| 1 Warning | |
|---|---|
| :warning: | Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.) |
Generated by :no_entry_sign: Danger
Test Results
64 files - 970 64 suites - 970 6m 24s :stopwatch: - 27m 57s 487 tests - 5 406 487 :white_check_mark: - 5 384 0 :zzz: - 22 0 :x: ±0 980 runs - 10 869 980 :white_check_mark: - 10 825 0 :zzz: - 44 0 :x: ±0
Results for commit 8f8d9c3d. ± Comparison against base commit 4128d9a7.
This pull request removes 5406 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…
:recycle: This comment has been updated with latest results.
Coverage Report 1
Affected Products
No changes between base commit (4128d9a) and merge commit (c5d40e9).Test Logs
- Base (4128d9a): https://github.com/firebase/firebase-android-sdk/actions/runs/13710851975
- Merge (c5d40e9): https://github.com/firebase/firebase-android-sdk/actions/runs/13728187559
Size Report 1
Affected Products
firebase-messagingType Base (4128d9a) Merge (0e5738e) Diff aar 149 kB 149 kB +47 B (+0.0%) apk (aggressive) 578 kB 578 kB -60 B (-0.0%) apk (release) 5.31 MB 5.31 MB +8 B (+0.0%)
Test Logs
- Base (4128d9a): https://github.com/firebase/firebase-android-sdk/actions/runs/13710851975
- Merge (0e5738e): https://github.com/firebase/firebase-android-sdk/actions/runs/13731434199