firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

Draft of possible api change

Open mrober opened this issue 1 year ago • 6 comments

mrober avatar Jul 30 '24 18:07 mrober

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html	2024-08-06 16:03:43.610710215 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html	2024-08-06 16:01:20.385904100 +0000
@@ -44,7 +44,16 @@
           <tr>
             <td><code>boolean</code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a>()</code></div>
+              <div><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Discouraged.html">Discouraged</a>(message&nbsp;=&nbsp;&quot;May not be current. Use didCrashOnPreviousRun instead.&quot;)<br><span><del><a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a></del></span>()</code></div>
+              <p><strong>This method is deprecated.</strong>
+                <p>May not be current.</p>
+              </p>
+            </td>
+          </tr>
+          <tr>
+            <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://developer.android.com/reference/kotlin/java/lang/Boolean.html">Boolean</a>&gt;</code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousRun()">didCrashOnPreviousRun</a>()</code></div>
               <p>Checks whether the app crashed on its previous run.</p>
             </td>
           </tr>
@@ -56,7 +65,7 @@
             </td>
           </tr>
           <tr>
-            <td><code>boolean</code></td>
+            <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://developer.android.com/reference/kotlin/java/lang/Boolean.html">Boolean</a>&gt;</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</a>()</code></div>
               <p>Indicates whether or not automatic data collection is enabled</p>
@@ -220,7 +229,10 @@
       </div>
       <div class="api-item"><a name="didCrashOnPreviousExecution--"></a><a name="didcrashonpreviousexecution"></a>
         <h3 class="api-name" id="didCrashOnPreviousExecution()">didCrashOnPreviousExecution</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;boolean&nbsp;<a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a>()</pre>
+        <pre class="api-signature no-pretty-print">@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Discouraged.html">Discouraged</a>(message&nbsp;=&nbsp;&quot;May not be current. Use didCrashOnPreviousRun instead.&quot;)<br>public&nbsp;boolean&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a></del></span>()</pre>
+        <aside class="caution"><strong>This method is deprecated.</strong><br>
+          <p>May not be current. Use didCrashOnPreviousRun instead. Will be removed in Q2 2025.</p>
+        </aside>
         <p>Checks whether the app crashed on its previous run.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -237,7 +249,33 @@
               <tr>
                 <td><code>boolean</code></td>
                 <td>
-                  <p>true if a crash was recorded during the previous run of the app.</p>
+                  <p>true if a crash was recorded during the previous run of the app. May not be current.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
+      <div class="api-item"><a name="didCrashOnPreviousRun--"></a><a name="didcrashonpreviousrun"></a>
+        <h3 class="api-name" id="didCrashOnPreviousRun()">didCrashOnPreviousRun</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://developer.android.com/reference/kotlin/java/lang/Boolean.html">Boolean</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousRun()">didCrashOnPreviousRun</a>()</pre>
+        <p>Checks whether the app crashed on its previous run.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://developer.android.com/reference/kotlin/java/lang/Boolean.html">Boolean</a>&gt;</code></td>
+                <td>
+                  <p>A Task that resolves to true if a crash was recorded during the previous run of the app</p>
                 </td>
               </tr>
             </tbody>
@@ -252,7 +290,7 @@
       </div>
       <div class="api-item"><a name="isCrashlyticsCollectionEnabled--"></a><a name="iscrashlyticscollectionenabled"></a>
         <h3 class="api-name" id="isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;boolean&nbsp;<a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</a>()</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://developer.android.com/reference/kotlin/java/lang/Boolean.html">Boolean</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</a>()</pre>
         <p>Indicates whether or not automatic data collection is enabled</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -267,9 +305,9 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>boolean</code></td>
+                <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://developer.android.com/reference/kotlin/java/lang/Boolean.html">Boolean</a>&gt;</code></td>
                 <td>
-                  <p>In order of priority: </p>
+                  <p>A Task that resolved in order of priority: </p>
                   <p>If <code><a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html#setCrashlyticsCollectionEnabled(boolean)">setCrashlyticsCollectionEnabled</a></code> is called with a value, use it </p>
                   <p>If the <b>firebase_crashlytics_collection_enabled</b> key is in your app’s AndroidManifest.xml, use it </p>
                   <p>Otherwise, use the default <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html#isDataCollectionDefaultEnabled()">isDataCollectionDefaultEnabled</a></code> in FirebaseApp</p>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html	2024-08-06 16:03:43.626710302 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html	2024-08-06 16:01:20.385904100 +0000
@@ -44,7 +44,16 @@
           <tr>
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a>()</code></div>
+              <div><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Discouraged.html">Discouraged</a>(message&nbsp;=&nbsp;&quot;May not be current. Use didCrashOnPreviousRun instead.&quot;)<br><span><del><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a></del></span>()</code></div>
+              <p><strong>This function is deprecated.</strong>
+                <p>May not be current.</p>
+              </p>
+            </td>
+          </tr>
+          <tr>
+            <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>!&gt;!</code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousRun()">didCrashOnPreviousRun</a>()</code></div>
               <p>Checks whether the app crashed on its previous run.</p>
             </td>
           </tr>
@@ -56,7 +65,7 @@
             </td>
           </tr>
           <tr>
-            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></code></td>
+            <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>!&gt;!</code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</a>()</code></div>
               <p>Indicates whether or not automatic data collection is enabled</p>
@@ -220,7 +229,10 @@
       </div>
       <div class="api-item"><a name="didCrashOnPreviousExecution--"></a><a name="didcrashonpreviousexecution"></a>
         <h3 class="api-name" id="didCrashOnPreviousExecution()">didCrashOnPreviousExecution</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></pre>
+        <pre class="api-signature no-pretty-print">@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Discouraged.html">Discouraged</a>(message&nbsp;=&nbsp;&quot;May not be current. Use didCrashOnPreviousRun instead.&quot;)<br>fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousExecution()">didCrashOnPreviousExecution</a></del></span>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></pre>
+        <aside class="caution"><strong>This function is deprecated.</strong><br>
+          <p>May not be current. Use didCrashOnPreviousRun instead. Will be removed in Q2 2025.</p>
+        </aside>
         <p>Checks whether the app crashed on its previous run.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -237,7 +249,33 @@
               <tr>
                 <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></code></td>
                 <td>
-                  <p>true if a crash was recorded during the previous run of the app.</p>
+                  <p>true if a crash was recorded during the previous run of the app. May not be current.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
+      <div class="api-item"><a name="didCrashOnPreviousRun--"></a><a name="didcrashonpreviousrun"></a>
+        <h3 class="api-name" id="didCrashOnPreviousRun()">didCrashOnPreviousRun</h3>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#didCrashOnPreviousRun()">didCrashOnPreviousRun</a>():&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>!&gt;!</pre>
+        <p>Checks whether the app crashed on its previous run.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>!&gt;!</code></td>
+                <td>
+                  <p>A Task that resolves to true if a crash was recorded during the previous run of the app</p>
                 </td>
               </tr>
             </tbody>
@@ -252,7 +290,7 @@
       </div>
       <div class="api-item"><a name="isCrashlyticsCollectionEnabled--"></a><a name="iscrashlyticscollectionenabled"></a>
         <h3 class="api-name" id="isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#isCrashlyticsCollectionEnabled()">isCrashlyticsCollectionEnabled</a>():&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>!&gt;!</pre>
         <p>Indicates whether or not automatic data collection is enabled</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -267,9 +305,9 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></code></td>
+                <td><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>!&gt;!</code></td>
                 <td>
-                  <p>In order of priority: </p>
+                  <p>A Task that resolved in order of priority: </p>
                   <p>If <code><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html#setCrashlyticsCollectionEnabled(boolean)">setCrashlyticsCollectionEnabled</a></code> is called with a value, use it </p>
                   <p>If the <b>firebase_crashlytics_collection_enabled</b> key is in your app’s AndroidManifest.xml, use it </p>
                   <p>Otherwise, use the default <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html#isDataCollectionDefaultEnabled()">isDataCollectionDefaultEnabled</a></code> in FirebaseApp</p>

github-actions[bot] avatar Jul 30 '24 18:07 github-actions[bot]

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 11.14% (0605925) to 11.13% (d5c0163) by -0.00%.

    FilenameBase (0605925)Merge (d5c0163)Diff
    CrashlyticsCore.java0.61%0.61%-0.00%

Test Logs

google-oss-bot avatar Jul 30 '24 18:07 google-oss-bot

The public api surface has changed for the subproject firebase-crashlytics_api.txt:

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot avatar Jul 30 '24 18:07 google-oss-bot

Unit Test Results

  8 files  +  4    8 suites  +4   29s :stopwatch: +26s 22 tests  - 28  22 :heavy_check_mark:  - 28  0 :zzz: ±0  0 :x: ±0  44 runs   - 56  44 :heavy_check_mark:  - 56  0 :zzz: ±0  0 :x: ±0 

Results for commit 26338c70. ± Comparison against base commit 06059255.

This pull request removes 50 and adds 22 tests. Note that renamed tests count towards both.
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ long reply
com.google.firebase.vertexai.StreamingSnapshotTests ‑ malformed content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ prompt blocked for safety
com.google.firebase.vertexai.StreamingSnapshotTests ‑ quotes escaped
…
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 30 '24 18:07 github-actions[bot]

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (0605925)Merge (d5c0163)Diff
    aar416 kB416 kB+434 B (+0.1%)
    apk (release)5.85 MB5.85 MB+216 B (+0.0%)

Test Logs

google-oss-bot avatar Jul 30 '24 18:07 google-oss-bot

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile0605925d5c0163DiffSignificant (?)
    p1010.7 ±3 ms12.1 ±3 ms+1.36 ms (+12.7%)NO
    p2511.4 ±3 ms12.9 ±3 ms+1.44 ms (+12.6%)NO
    p5012.4 ±3 ms14.0 ±4 ms+1.62 ms (+13.1%)NO
    p7513.8 ±3 ms15.4 ±4 ms+1.60 ms (+11.6%)NO
    p9015.4 ±3 ms17.1 ±4 ms+1.79 ms (+11.6%)NO

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG
    redfin-30
    Percentile0605925d5c0163DiffSignificant (?)
    p1014.0 ±5 ms12.8 ±1 ms-1.22 ms (-8.8%)NO
    p2514.6 ±5 ms13.3 ±1 ms-1.33 ms (-9.1%)NO
    p5015.5 ±6 ms14.0 ±2 ms-1.48 ms (-9.5%)NO
    p7516.6 ±6 ms15.2 ±2 ms-1.44 ms (-8.6%)NO
    p9018.7 ±7 ms17.2 ±3 ms-1.46 ms (-7.8%)NO

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG
  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentile0605925d5c0163DiffSignificant (?)
    p10296 ±428 μs217 ±430 μs-79.7 μs (-26.9%)NO
    p25317 ±455 μs226 ±445 μs-90.7 μs (-28.6%)NO
    p50408 ±631 μs240 ±463 μs-168 μs (-41.2%)NO
    p75453 ±667 μs268 ±492 μs-185 μs (-40.8%)NO
    p90519 ±727 μs344 ±589 μs-175 μs (-33.8%)NO

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG
    redfin-30
    Percentile0605925d5c0163DiffSignificant (?)
    p10387 ±324 μs688 ±689 μs+301 μs (+77.7%)NO
    p25444 ±371 μs767 ±775 μs+323 μs (+72.9%)NO
    p50584 ±513 μs922 ±918 μs+338 μs (+58.0%)NO
    p75776 ±685 μs1.19 ±1 ms+409 μs (+52.8%)NO
    p90951 ±835 μs1.52 ±1 ms+571 μs (+60.1%)NO

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentile0605925d5c0163DiffSignificant (?)
    p103.22 ±0.6 ms2.54 ±0.6 ms-680 μs (-21.2%)NO
    p253.43 ±0.6 ms2.71 ±0.7 ms-722 μs (-21.1%)NO
    p503.78 ±0.7 ms3.04 ±0.8 ms-732 μs (-19.4%)NO
    p754.31 ±0.9 ms3.56 ±0.8 ms-747 μs (-17.3%)NO
    p905.09 ±1 ms4.34 ±1 ms-745 μs (-14.6%)NO

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG
    redfin-30
    Percentile0605925d5c0163DiffSignificant (?)
    p106.45 ±2 ms6.38 ±2 ms-69.0 μs (-1.1%)NO
    p256.85 ±2 ms6.93 ±2 ms+85.3 μs (+1.2%)NO
    p507.57 ±3 ms7.60 ±3 ms+39.8 μs (+0.5%)NO
    p758.44 ±4 ms8.56 ±4 ms+124 μs (+1.5%)NO
    p909.45 ±5 ms9.95 ±5 ms+505 μs (+5.3%)NO

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile0605925d5c0163DiffSignificant (?)
    p10203 ±5 ms208 ±10 ms+4.40 ms (+2.2%)NO
    p25210 ±8 ms214 ±11 ms+3.71 ms (+1.8%)NO
    p50217 ±9 ms221 ±11 ms+4.11 ms (+1.9%)NO
    p75227 ±18 ms230 ±14 ms+2.26 ms (+1.0%)NO
    p90238 ±24 ms240 ±16 ms+1.67 ms (+0.7%)NO

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG
    redfin-30
    Percentile0605925d5c0163DiffSignificant (?)
    p10243 ±4 ms265 ±4 ms+22.5 ms (+9.3%)YES
    p25248 ±4 ms271 ±5 ms+23.1 ms (+9.3%)YES
    p50254 ±4 ms279 ±7 ms+25.0 ms (+9.8%)MAYBE
    p75262 ±4 ms289 ±9 ms+27.0 ms (+10.3%)MAYBE
    p90271 ±5 ms304 ±10 ms+32.3 ms (+11.9%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    0605925
    • 2024-08-01_18:52:00.532303_SLOK
    • 2024-08-01_18:52:00.532346_CWfI
    • 2024-08-01_18:52:00.532362_fZYq
    • 2024-08-01_18:52:00.532371_kONs
    • 2024-08-01_18:52:00.532378_yAge
    • 2024-08-01_18:52:00.532385_AGza
    • 2024-08-01_18:52:00.532392_BSkV
    • 2024-08-01_18:52:00.532398_qYNK
    • 2024-08-01_18:52:00.532405_vYhU
    • 2024-08-01_18:52:00.532411_qOyp
    d5c0163
    • 2024-08-06_16:10:50.724899_AQmI
    • 2024-08-06_16:10:50.724942_HYVa
    • 2024-08-06_16:10:50.724953_ShNj
    • 2024-08-06_16:10:50.724961_fDrM
    • 2024-08-06_16:10:50.724968_GcbQ
    • 2024-08-06_16:10:50.724976_DmLK
    • 2024-08-06_16:10:50.724983_LZnu
    • 2024-08-06_16:10:50.724990_aYhc
    • 2024-08-06_16:10:50.724997_Xejg
    • 2024-08-06_16:10:50.725003_JykG

google-oss-bot avatar Jul 30 '24 18:07 google-oss-bot