firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

Force validation or rotation of FIDs in Sessions

Open mrober opened this issue 2 years ago • 6 comments

mrober avatar Jan 29 '24 19:01 mrober

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions[bot] avatar Jan 29 '24 19:01 github-actions[bot]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions[bot] avatar Jan 29 '24 19:01 github-actions[bot]

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from 74.02% (52a31e2) to 74.00% (fd7302f) by -0.02%.

    FilenameBase (52a31e2)Merge (fd7302f)Diff
    RemoteSettings.kt88.57%87.50%-1.07%
    SessionFirelogPublisher.kt80.49%80.95%+0.46%

Test Logs

google-oss-bot avatar Jan 29 '24 19:01 google-oss-bot

Unit Test Results

   136 files   -    812     136 suites   - 812   3m 0s :stopwatch: - 28m 22s 1 055 tests  - 4 123  1 055 :heavy_check_mark:  - 4 102  0 :zzz:  - 21  0 :x: ±0  2 110 runs   - 8 331  2 110 :heavy_check_mark:  - 8 289  0 :zzz:  - 42  0 :x: ±0 

Results for commit 6c419913. ± Comparison against base commit 52a31e22.

github-actions[bot] avatar Jan 29 '24 19:01 github-actions[bot]

Size Report 1

Affected Products

  • firebase-sessions

    TypeBase (52a31e2)Merge (fd7302f)Diff
    aar163 kB163 kB+340 B (+0.2%)
    apk (aggressive)762 kB764 kB+2.42 kB (+0.3%)
    apk (release)5.77 MB5.77 MB+392 B (+0.0%)

Test Logs

google-oss-bot avatar Jan 29 '24 19:01 google-oss-bot

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-perf

    DeviceStatisticsDistributions
    oriole-32
    Percentile52a31e2fd7302fDiffSignificant (?)
    p10307 ±162 μs256 ±28 μs-51.2 μs (-16.7%)NO
    p25322 ±162 μs266 ±27 μs-55.3 μs (-17.2%)NO
    p50341 ±163 μs288 ±30 μs-52.4 μs (-15.4%)NO
    p75380 ±160 μs367 ±132 μs-13.5 μs (-3.5%)NO
    p90439 ±155 μs440 ±138 μs+1.24 μs (+0.3%)NO

    20 test runs in comparison
    CommitTest Runs
    52a31e2
    • 2024-01-27_04:43:45.634190_hhYz
    • 2024-01-27_04:43:45.634230_zssR
    • 2024-01-27_04:43:45.634237_VEpD
    • 2024-01-27_04:43:45.634243_aPNV
    • 2024-01-27_04:43:45.634249_RrqL
    • 2024-01-27_04:43:45.634258_umCN
    • 2024-01-27_04:43:45.634277_jFHs
    • 2024-01-27_04:43:45.634285_VRpK
    • 2024-01-27_04:43:45.634292_Rjnw
    • 2024-01-27_04:43:45.634299_dZXt
    fd7302f
    • 2024-01-29_19:33:26.006801_DVec
    • 2024-01-29_19:33:26.006835_oCAe
    • 2024-01-29_19:33:26.006847_hiaw
    • 2024-01-29_19:33:26.006855_Xfkw
    • 2024-01-29_19:33:26.006864_vzWT
    • 2024-01-29_19:33:26.006871_LacX
    • 2024-01-29_19:33:26.006885_fiVh
    • 2024-01-29_19:33:26.006892_uQGJ
    • 2024-01-29_19:33:26.006900_Xanr
    • 2024-01-29_19:33:26.006907_uPvn
    redfin-30
    Percentile52a31e2fd7302fDiffSignificant (?)
    p10752 ±217 μs723 ±55 μs-29.1 μs (-3.9%)NO
    p25796 ±214 μs774 ±64 μs-21.8 μs (-2.7%)NO
    p50913 ±228 μs889 ±174 μs-23.4 μs (-2.6%)NO
    p751.03 ±0.2 ms1.02 ±0.2 ms-6.93 μs (-0.7%)NO
    p901.17 ±0.2 ms1.22 ±0.2 ms+43.8 μs (+3.7%)NO

    20 test runs in comparison
    CommitTest Runs
    52a31e2
    • 2024-01-27_04:43:45.634190_hhYz
    • 2024-01-27_04:43:45.634230_zssR
    • 2024-01-27_04:43:45.634237_VEpD
    • 2024-01-27_04:43:45.634243_aPNV
    • 2024-01-27_04:43:45.634249_RrqL
    • 2024-01-27_04:43:45.634258_umCN
    • 2024-01-27_04:43:45.634277_jFHs
    • 2024-01-27_04:43:45.634285_VRpK
    • 2024-01-27_04:43:45.634292_Rjnw
    • 2024-01-27_04:43:45.634299_dZXt
    fd7302f
    • 2024-01-29_19:33:26.006801_DVec
    • 2024-01-29_19:33:26.006835_oCAe
    • 2024-01-29_19:33:26.006847_hiaw
    • 2024-01-29_19:33:26.006855_Xfkw
    • 2024-01-29_19:33:26.006864_vzWT
    • 2024-01-29_19:33:26.006871_LacX
    • 2024-01-29_19:33:26.006885_fiVh
    • 2024-01-29_19:33:26.006892_uQGJ
    • 2024-01-29_19:33:26.006900_Xanr
    • 2024-01-29_19:33:26.006907_uPvn
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentile52a31e2fd7302fDiffSignificant (?)
    p108.06 ±2 ms6.87 ±1 ms-1.19 ms (-14.7%)NO
    p258.43 ±2 ms7.32 ±1 ms-1.11 ms (-13.1%)NO
    p509.07 ±2 ms7.95 ±1 ms-1.12 ms (-12.3%)NO
    p7510.0 ±2 ms8.94 ±2 ms-1.07 ms (-10.7%)NO
    p9011.2 ±3 ms10.3 ±2 ms-884 μs (-7.9%)NO

    20 test runs in comparison
    CommitTest Runs
    52a31e2
    • 2024-01-27_04:43:45.634190_hhYz
    • 2024-01-27_04:43:45.634230_zssR
    • 2024-01-27_04:43:45.634237_VEpD
    • 2024-01-27_04:43:45.634243_aPNV
    • 2024-01-27_04:43:45.634249_RrqL
    • 2024-01-27_04:43:45.634258_umCN
    • 2024-01-27_04:43:45.634277_jFHs
    • 2024-01-27_04:43:45.634285_VRpK
    • 2024-01-27_04:43:45.634292_Rjnw
    • 2024-01-27_04:43:45.634299_dZXt
    fd7302f
    • 2024-01-29_19:33:26.006801_DVec
    • 2024-01-29_19:33:26.006835_oCAe
    • 2024-01-29_19:33:26.006847_hiaw
    • 2024-01-29_19:33:26.006855_Xfkw
    • 2024-01-29_19:33:26.006864_vzWT
    • 2024-01-29_19:33:26.006871_LacX
    • 2024-01-29_19:33:26.006885_fiVh
    • 2024-01-29_19:33:26.006892_uQGJ
    • 2024-01-29_19:33:26.006900_Xanr
    • 2024-01-29_19:33:26.006907_uPvn
    redfin-30
    Percentile52a31e2fd7302fDiffSignificant (?)
    p1012.3 ±3 ms11.9 ±2 ms-419 μs (-3.4%)NO
    p2513.3 ±4 ms12.6 ±3 ms-693 μs (-5.2%)NO
    p5014.8 ±5 ms14.0 ±4 ms-810 μs (-5.5%)NO
    p7519.7 ±4 ms18.3 ±3 ms-1.38 ms (-7.0%)NO
    p9021.8 ±5 ms21.2 ±4 ms-677 μs (-3.1%)NO

    20 test runs in comparison
    CommitTest Runs
    52a31e2
    • 2024-01-27_04:43:45.634190_hhYz
    • 2024-01-27_04:43:45.634230_zssR
    • 2024-01-27_04:43:45.634237_VEpD
    • 2024-01-27_04:43:45.634243_aPNV
    • 2024-01-27_04:43:45.634249_RrqL
    • 2024-01-27_04:43:45.634258_umCN
    • 2024-01-27_04:43:45.634277_jFHs
    • 2024-01-27_04:43:45.634285_VRpK
    • 2024-01-27_04:43:45.634292_Rjnw
    • 2024-01-27_04:43:45.634299_dZXt
    fd7302f
    • 2024-01-29_19:33:26.006801_DVec
    • 2024-01-29_19:33:26.006835_oCAe
    • 2024-01-29_19:33:26.006847_hiaw
    • 2024-01-29_19:33:26.006855_Xfkw
    • 2024-01-29_19:33:26.006864_vzWT
    • 2024-01-29_19:33:26.006871_LacX
    • 2024-01-29_19:33:26.006885_fiVh
    • 2024-01-29_19:33:26.006892_uQGJ
    • 2024-01-29_19:33:26.006900_Xanr
    • 2024-01-29_19:33:26.006907_uPvn
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile52a31e2fd7302fDiffSignificant (?)
    p10205 ±5 ms208 ±3 ms+2.32 ms (+1.1%)NO
    p25211 ±4 ms214 ±3 ms+2.25 ms (+1.1%)NO
    p50219 ±4 ms222 ±4 ms+2.72 ms (+1.2%)NO
    p75228 ±4 ms232 ±5 ms+3.98 ms (+1.7%)NO
    p90237 ±6 ms241 ±6 ms+4.64 ms (+2.0%)NO

    20 test runs in comparison
    CommitTest Runs
    52a31e2
    • 2024-01-27_04:43:45.634190_hhYz
    • 2024-01-27_04:43:45.634230_zssR
    • 2024-01-27_04:43:45.634237_VEpD
    • 2024-01-27_04:43:45.634243_aPNV
    • 2024-01-27_04:43:45.634249_RrqL
    • 2024-01-27_04:43:45.634258_umCN
    • 2024-01-27_04:43:45.634277_jFHs
    • 2024-01-27_04:43:45.634285_VRpK
    • 2024-01-27_04:43:45.634292_Rjnw
    • 2024-01-27_04:43:45.634299_dZXt
    fd7302f
    • 2024-01-29_19:33:26.006801_DVec
    • 2024-01-29_19:33:26.006835_oCAe
    • 2024-01-29_19:33:26.006847_hiaw
    • 2024-01-29_19:33:26.006855_Xfkw
    • 2024-01-29_19:33:26.006864_vzWT
    • 2024-01-29_19:33:26.006871_LacX
    • 2024-01-29_19:33:26.006885_fiVh
    • 2024-01-29_19:33:26.006892_uQGJ
    • 2024-01-29_19:33:26.006900_Xanr
    • 2024-01-29_19:33:26.006907_uPvn
    redfin-30
    Percentile52a31e2fd7302fDiffSignificant (?)
    p10249 ±5 ms276 ±8 ms+27.0 ms (+10.9%)MAYBE
    p25255 ±6 ms283 ±9.7 ms+27.7 ms (+10.8%)MAYBE
    p50263 ±6 ms293 ±11 ms+30.1 ms (+11.5%)MAYBE
    p75271 ±6 ms304 ±13 ms+32.4 ms (+12.0%)NO
    p90280 ±7 ms320 ±12 ms+39.8 ms (+14.2%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    52a31e2
    • 2024-01-27_04:43:45.634190_hhYz
    • 2024-01-27_04:43:45.634230_zssR
    • 2024-01-27_04:43:45.634237_VEpD
    • 2024-01-27_04:43:45.634243_aPNV
    • 2024-01-27_04:43:45.634249_RrqL
    • 2024-01-27_04:43:45.634258_umCN
    • 2024-01-27_04:43:45.634277_jFHs
    • 2024-01-27_04:43:45.634285_VRpK
    • 2024-01-27_04:43:45.634292_Rjnw
    • 2024-01-27_04:43:45.634299_dZXt
    fd7302f
    • 2024-01-29_19:33:26.006801_DVec
    • 2024-01-29_19:33:26.006835_oCAe
    • 2024-01-29_19:33:26.006847_hiaw
    • 2024-01-29_19:33:26.006855_Xfkw
    • 2024-01-29_19:33:26.006864_vzWT
    • 2024-01-29_19:33:26.006871_LacX
    • 2024-01-29_19:33:26.006885_fiVh
    • 2024-01-29_19:33:26.006892_uQGJ
    • 2024-01-29_19:33:26.006900_Xanr
    • 2024-01-29_19:33:26.006907_uPvn

google-oss-bot avatar Jan 29 '24 19:01 google-oss-bot