firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

Diff ABT Experiments for real-time RC

Open qdpham13 opened this issue 2 years ago • 7 comments

Adds diffing logic between experiments fetched via real-time and experiments active on the device. The config keys that have been affected by the differences will be added to ConfigUpdate.

qdpham13 avatar Jun 04 '23 03:06 qdpham13

Release note changes

No release note changes were detected. If you made changes that should be present in the next release, ensure you've added an entry in the appropriate CHANGELOG.md file(s).

github-actions[bot] avatar Jun 04 '23 03:06 github-actions[bot]

1 Warning
:warning: Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by :no_entry_sign: Danger

google-oss-bot avatar Jun 04 '23 03:06 google-oss-bot

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (da0c550) to 81.60% (b660681) by ?.

    30 individual files with coverage change

    FilenameBase (da0c550)Merge (b660681)Diff
    AutoValue_ConfigUpdate.java?29.41%?
    Code.java?0.00%?
    ConfigAutoFetch.java?87.74%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?92.97%?
    ConfigFetchHandler.java?92.86%?
    ConfigFetchHttpClient.java?86.81%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigMetadataClient.java?92.31%?
    ConfigRealtimeHandler.java?41.38%?
    ConfigRealtimeHttpClient.java?47.34%?
    ConfigStorageClient.java?100.00%?
    ConfigUpdate.java?100.00%?
    ConfigUpdateListener.java?0.00%?
    ConfigUpdateListenerRegistration.java?0.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?86.67%?
    FirebaseRemoteConfigClientException.java?75.00%?
    FirebaseRemoteConfigException.java?95.65%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?68.42%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfigComponent.java?89.61%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?

Test Logs

google-oss-bot avatar Jun 04 '23 03:06 google-oss-bot

Unit Test Results

  28 files   -    741    28 suites   - 741   1m 22s :stopwatch: - 31m 20s 281 tests  - 4 630  281 :heavy_check_mark:  - 4 608  0 :zzz:  - 21  0 :x:  - 1  562 runs   - 8 698  562 :heavy_check_mark:  - 8 655  0 :zzz:  - 42  0 :x:  - 1 

Results for commit 1a4ba9c4. ± Comparison against base commit 7b940f82.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 04 '23 03:06 github-actions[bot]

Size Report 1

Affected Products

  • firebase-config

    TypeBase (da0c550)Merge (b660681)Diff
    aar88.9 kB89.8 kB+912 B (+1.0%)
    apk (aggressive)151 kB152 kB+244 B (+0.2%)
    apk (release)1.32 MB1.32 MB+252 B (+0.0%)

Test Logs

google-oss-bot avatar Jun 04 '23 04:06 google-oss-bot

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (b660681) and the base commit (da0c550) are not available.

No macrobenchmark data found for the base commit (da0c550). Analysis for the CI merge commit (b660681) can be found at:

google-oss-bot avatar Jun 04 '23 04:06 google-oss-bot

@danasilver did E2E testing with the current SDK changes.

  1. Created experiments with https://docs.google.com/document/d/1MXxUg1JSBbh3m_Qy4tGPrGs3-Nh8FAwKmg5ZWOKQ3J8/edit

  2. Add experiments to configs using Management API, example: https://rpc.corp.google.com/rpc/builder?rpcId=15352346049097272373

2.1) Add/Remove Experiment to Config Key. 2.2) Replace experiment in Config Key 2.3) Create new param with experiment attached

  1. See changes in SDK

qdpham13 avatar Jun 05 '23 22:06 qdpham13