firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard
verified publisher icon firebase

Make FiresiteTransform a Cacheable task

Open daymxn opened this issue 3 years ago • 4 comments

In an effort to make the DackkaPlugin tasks all cache compliant (per b/243833009), the only remaining task that was not already cache complaint was FiresiteTransform. This PR fixes that.

More specifically, we now copy the transformed files into a new directory labeled dackkaTransformedFiles, versus working on the same files that Dackka outputs. This allows gradle to check if the files have actually changed, and pass an UP-TO-DATE-CHECK as needed.

Build time has dropped from ~50 seconds to only ~15 seconds, that's a 333% decrease!

daymxn avatar Sep 21 '22 18:09 daymxn

buildSrc Test Results

18 tests   18 :heavy_check_mark:  3m 3s :stopwatch:   4 suites    0 :zzz:   4 files      0 :x:

Results for commit 9b40dbad.

github-actions[bot] avatar Sep 21 '22 18:09 github-actions[bot]

Size Report 1

Affected Products

No changes between base commit (523730a) and merge commit (9329f39).

Test Logs

google-oss-bot avatar Sep 21 '22 18:09 google-oss-bot

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (523730a) to 79.31% (9329f39) by ?.

    34 individual files with coverage change

    FilenameBase (523730a)Merge (9329f39)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?94.90%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?92.59%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?53.33%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.19%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

  • firebase-database

    Overall coverage changed from 50.18% (523730a) to 50.21% (9329f39) by +0.03%.

    FilenameBase (523730a)Merge (9329f39)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    QueryParams.java90.36%89.76%-0.60%

  • firebase-firestore

    Overall coverage changed from 44.25% (523730a) to 44.26% (9329f39) by +0.00%.

    FilenameBase (523730a)Merge (9329f39)Diff
    SetMutation.java94.44%97.22%+2.78%

  • firebase-messaging

    Overall coverage changed from 85.14% (523730a) to 85.26% (9329f39) by +0.12%.

    FilenameBase (523730a)Merge (9329f39)Diff
    FirebaseMessaging.java75.77%76.21%+0.44%
    RequestDeduplicator.java80.00%90.00%+10.00%

  • firebase-storage

    Overall coverage changed from ? (523730a) to 86.24% (9329f39) by ?.

    46 individual files with coverage change

    FilenameBase (523730a)Merge (9329f39)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?85.11%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.67%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?33.33%?
    SmartHandler.java?87.50%?
    StorageException.java?69.09%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?84.59%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?100.00%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?82.73%?
    Util.java?73.24%?

Test Logs

google-oss-bot avatar Sep 21 '22 19:09 google-oss-bot

Unit Test Results

   394 files  +  4     394 suites  +4   17m 7s :stopwatch: +12s 4 713 tests +10  4 691 :heavy_check_mark: +10  22 :zzz: ±0  0 :x: ±0  4 729 runs  +10  4 707 :heavy_check_mark: +10  22 :zzz: ±0  0 :x: ±0 

Results for commit 9b40dbad. ± Comparison against base commit 523730a3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 21 '22 19:09 github-actions[bot]