firebase-admin-python icon indicating copy to clipboard operation
firebase-admin-python copied to clipboard

[FR] Update ActionCodeSettings to support link_domain

Open huwmartin opened this issue 7 months ago • 2 comments

Is your feature request related to a problem? Please describe.

Firebase Dynamic Links will stop working August 25th 2025.

Migration instructions indicate that to use a custom domain one should update usage of ActionCodeSettings to use linkDomain, see also in the Firebase Admin docs.

We currently depend upon firebase-admin-python generate_sign_in_with_email_link to generate email links, firebase-admin-python hasn't been updated with link_domain and currently only supports dynamic_link_domain, firebase-admin-node has been updated with support for linkDomain so I assume this should be officially supported, please let me know if this is not the case.

Describe the solution you'd like

ActionCodeSettings should be updated to accept link_domain and encode_action_code_settings should be updated to handle link_domain.

huwmartin avatar May 30 '25 11:05 huwmartin

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar May 30 '25 11:05 google-oss-bot

Opened a PR for this here https://github.com/firebase/firebase-admin-python/pull/884

huwmartin avatar Jun 12 '25 10:06 huwmartin

@lahirumaramba @pashanka would you be interested in reviewing the PR I've opened to address this here https://github.com/firebase/firebase-admin-python/pull/884. In my org we're currently relying on this via a fork and would be great to get into main release.

huwmartin avatar Jun 25 '25 11:06 huwmartin

Hey folks, this is now available in v7.1.0.

jonathanedey avatar Aug 01 '25 14:08 jonathanedey