firebase-admin-python icon indicating copy to clipboard operation
firebase-admin-python copied to clipboard

AppStoreId property missing

Open ihor-parmon opened this issue 3 years ago • 2 comments

Env:

  • Operating System version: macOS Big Sur
  • Firebase SDK version: 5.2.0
  • Firebase Product: project_management
  • Python version: 3.10
  • Pip version: 21.1.2

Problem:

How can I create an iOS app with appStoreId using Project Management API ?

Firebase documentation (https://firebase.google.com/docs/projects/api/reference/rest/v1beta1/projects.iosApps#IosApp) contains definition of the iOSApp { "name": string, "appId": string, "displayName": string, "projectId": string, "bundleId": string, "appStoreId": string } and states that creation request accepts instance of an iOSApp.

However method provided in the firebase_admin.project_management implementation provides ability to pass only bundle_id and display_name.

ihor-parmon avatar May 24 '22 07:05 ihor-parmon

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar May 24 '22 07:05 google-oss-bot

Thanks @ihoregym for filing this issue. The appStoreId property needs to be added to the create_ios_app() API. https://github.com/firebase/firebase-admin-python/blob/6d826fd15c87db62f7501f569b6e0a762d17a05e/firebase_admin/project_management.py#L104

and also added to the internal implementation of the service below.

https://github.com/firebase/firebase-admin-python/blob/6d826fd15c87db62f7501f569b6e0a762d17a05e/firebase_admin/project_management.py#L584

This is not something we have currently prioritized and we are unable to promise a timeline on this. Any change to the public API surface should also go through an internal approval process. Let's use this issue to track any updates.

In the meantime, if you or anyone else from the community would like to take a stab at it we always glad to review any PRs. Thank you!

lahirumaramba avatar Jun 28 '22 20:06 lahirumaramba