firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

Add option to specify local address for http requests.

Open NicholasMendes opened this issue 7 years ago • 4 comments

This commit allows the user to specify an address to route the http requests, this is useful if for example your network connection is limited and only available through a given address.

Closes: #411

NicholasMendes avatar Dec 10 '18 15:12 NicholasMendes

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Dec 10 '18 15:12 googlebot

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot avatar Dec 11 '18 09:12 googlebot

I signed it!

NicholasMendes avatar Dec 11 '18 09:12 NicholasMendes

CLAs look good, thanks!

googlebot avatar Dec 11 '18 10:12 googlebot