firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

[FR]Why does admin.send() return just the response name as error instead of the full response object

Open nero2009 opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe.

I need to be able handle and cleanup tokens that have expired or are not working for whatever reason. I just migrated from sendToDevice to send and I was surprise that only a string response/error is returned when send is called.

Describe the solution you'd like

A response object that contains status, error code and message

similar to the return type of the now deprecated sendToDevice method

export interface FirebaseError {

code: string;

message: string;

stack?: string;

toJSON(): object;

}

Describe alternatives you've considered

There is no exhaustive list of all the error so there is no way for me to know when to remove expired token from my DB or keep them

Additional context

it is a bit wierd that other methods get a proper error object but send just gets a string error

nero2009 avatar Sep 03 '24 14:09 nero2009

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

google-oss-bot avatar Sep 03 '24 14:09 google-oss-bot

False alarm because an Error object is returned but documentation can be improved

https://firebase.google.com/docs/reference/admin/node/firebase-admin.messaging.messaging.md#messagingsend

send returns an Error object on error.

Please update docs to show what the Error object is return when send fails

nero2009 avatar Sep 04 '24 08:09 nero2009