firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

[FR] adding toJSON property to the Admin SDK Timestamp class

Open tlserver opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. Working in monorepos or other situations with shared Typescript interfaces is complicated because toJSON property is missing on the Admin SDK Timestamp definition

Can firebase-admin package and firebase package share same type definition of some common class? For example firebase-admin Timestamp class is defined here but firebase Timestamp class is defined here and they are different.

Describe the solution you'd like adding toJSON property to the Admin SDK Timestamp class to make it compatible to firebase Timestamp class.

Describe alternatives you've considered Split the common class type definition to a separate package?

Additional context Discussed at #1404 before, but no contributor response after hiranya911 is not active in firebase project.

tlserver avatar Dec 14 '23 08:12 tlserver

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

google-oss-bot avatar Dec 14 '23 08:12 google-oss-bot